New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix leaking sw_vers #10630

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
5 participants
@casz
Contributor

casz commented Oct 18, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

system('sw_vers') was leaking output:

ProductName:	Mac OS X
ProductVersion:	10.13
BuildVersion:	17A405

Simply running fastlane shows sw_vers info...

Captured Output

Command Used: fastlane

Output/Log
                                                                                                                                                                                                    
[13:08:52]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
ProductName:	Mac OS X
ProductVersion:	10.13
BuildVersion:	17A405
[13:08:54]: Welcome to fastlane! Here's what your app is setup to do:
+--------+-----------------+------------------------------+
|                 Available lanes to run                  |
+--------+-----------------+------------------------------+
| Number | Lane Name       | Description                  |
+--------+-----------------+------------------------------+
| 1      | devices         |                              |
| 0      | cancel          | No selection, exit fastlane! |
+--------+-----------------+------------------------------+
[13:08:54]: Which number would you like run?
0

[!] Run `fastlane` the next time you need to build, test or release your app 馃殌


@@ -191,7 +191,7 @@ def operating_system_version
os = self.operating_system
case os
when "macOS"
return system('sw_vers') ? `sw_vers -productVersion`.strip : 'unknown'
return system('sw_vers', out: File::NULL) ? `sw_vers -productVersion`.strip : 'unknown'

This comment has been minimized.

@casz

casz Oct 18, 2017

Contributor

@ohayon please take a look 馃憤

@casz

casz Oct 18, 2017

Contributor

@ohayon please take a look 馃憤

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Oct 18, 2017

Member

Hey @casz, thanks for the PR, I noticed that also when using fastlane, do you know when this was introduced? Is that because of a new Xcode version?

Member

KrauseFx commented Oct 18, 2017

Hey @casz, thanks for the PR, I noticed that also when using fastlane, do you know when this was introduced? Is that because of a new Xcode version?

@casz

This comment has been minimized.

Show comment
Hide comment
@casz

casz Oct 18, 2017

Contributor

@KrauseFx nah it was introduced in #10625 :)
Looking at the commits, the file is only 2 days old 馃憤

Contributor

casz commented Oct 18, 2017

@KrauseFx nah it was introduced in #10625 :)
Looking at the commits, the file is only 2 days old 馃憤

@mpirri

mpirri approved these changes Oct 18, 2017

Thanks for catching this, @casz ! 馃挴

@mpirri mpirri merged commit 2e52678 into fastlane:master Oct 18, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Oct 19, 2017

Hey @casz 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

fastlane-bot commented Oct 19, 2017

Hey @casz 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

@ohayon ohayon referenced this pull request Oct 23, 2017

Merged

Version bump to 2.62.1 #10670

laullon added a commit to laullon/fastlane that referenced this pull request Oct 23, 2017

Merge branch 'master' into snapshot-record-video
* master: (96 commits)
  [snapshot] Fix unused result warning in helper (fastlane#10662)
  Typo Fix (fastlane#10661)
  Version bump to 2.62.1 (fastlane#10670)
  Support manual signingStyle (fastlane#10508)
  Dont count lane switches in metrics (fastlane#10659)
  Add missing html tag (fastlane#10657)
  Deprecates add_id_info_limits_tracking in favor of add_id_info_uses_idfa (fastlane#10653)
  [fastlane core] fix unit tests when Xcode 9.0 not installed (fastlane#10655)
  Add automatic commiting of mkdocs.yml for docs generation (fastlane#10578)
  [Client] Handle Faraday::ParsingError as part of Client#with_retry logic (fastlane#10646)
  Revert "[BuildWatcher] Handle parse error while waiting for build processing (fastlane#10621)" (fastlane#10647)
  [BuildWatcher] Handle parse error while waiting for build processing (fastlane#10621)
  Remove 'zip' example from update_info_plist (fastlane#10494)
  Make plugin details optional (fastlane#10628)
  fix leaking sw_vers (fastlane#10630)
  Update snapshot instructions (fastlane#10626)
  Update update instructions of snapshot (fastlane#10627)
  Don't add unneeded new-line when asking for user input (fastlane#10629)
  Forward match keychain password into cert (fastlane#10619)
  SW_VERS should be lowercase (fastlane#10625)
  ...

# Conflicts:
#	README.md
#	cert/README.md
#	snapshot/README.md
#	snapshot/lib/assets/SnapshotHelper.swift
@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Oct 24, 2017

Congratulations! 馃帀 This was released as part of fastlane 2.62.1 馃殌

fastlane-bot commented Oct 24, 2017

Congratulations! 馃帀 This was released as part of fastlane 2.62.1 馃殌

@fastlane fastlane locked and limited conversation to collaborators Dec 23, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.