Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue template fix #10673

Merged
merged 2 commits into from Oct 31, 2017
Merged

issue template fix #10673

merged 2 commits into from Oct 31, 2017

Conversation

RishabhTayal
Copy link
Contributor

@RishabhTayal RishabhTayal commented Oct 23, 2017 •
edited

In the current ISSUE_TEMPLATE.md there are some instructions for the issue author. Those instructions need to be deleted by author every time. We can add those instructions as commented code instead. This PR achieves that. Hope to get this merged. 馃憤

Followup of existing PR: #10437

@ohayon
Copy link
Contributor

ohayon commented Oct 24, 2017

Hey @RishabhTayal! Thanks for recreating this PR! I'm not so sure I understand the intention of this change though. Could you explain a bit more what is wrong with the current template? It's okay if people do not delete those instructions. 馃悪

ohayon
ohayon approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RishabhTayal !! 馃殌

@ohayon ohayon merged commit 6933a38 into fastlane:master Oct 31, 2017
@fastlane-bot
Copy link

Hey @RishabhTayal 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

@KrauseFx KrauseFx mentioned this pull request Nov 6, 2017
Merged
@fastlane-bot
Copy link

Congratulations! 馃帀 This was released as part of fastlane 2.64.0 馃殌

@fastlane fastlane locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ohayon ohayon ohayon approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RishabhTayal @ohayon @fastlane-bot @googlebot