New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wercker git_branch ENV variable check #10683

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
4 participants
@chibatching
Contributor

chibatching commented Oct 24, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The git_branch action seems to return an empty string when run in wercker.

Description

I added the ENV check for WERCKER_GIT_BRANCH.
Available Environment Variables in wercker

@googlebot

This comment has been minimized.

googlebot commented Oct 24, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no label Oct 24, 2017

@chibatching

This comment has been minimized.

Contributor

chibatching commented Oct 24, 2017

I signed it!

@googlebot

This comment has been minimized.

googlebot commented Oct 24, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 24, 2017

@ohayon

ohayon approved these changes Oct 24, 2017

Sweet! Thanks @chibatching !!!

@ohayon ohayon merged commit 5c196d3 into fastlane:master Oct 24, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

@chibatching chibatching deleted the chibatching:add_wercker_git_branch branch Oct 24, 2017

@fastlane-bot

This comment has been minimized.

fastlane-bot commented Oct 25, 2017

Hey @chibatching 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot

This comment has been minimized.

fastlane-bot commented Nov 1, 2017

Congratulations! 🎉 This was released as part of fastlane 2.63.0 🚀

RishabhTayal added a commit to RishabhTayal/fastlane that referenced this pull request Dec 22, 2017

@fastlane fastlane locked and limited conversation to collaborators Dec 31, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.