Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require for frame_screenshots #11064

Merged
merged 1 commit into from Nov 30, 2017
Merged

Fix require for frame_screenshots #11064

merged 1 commit into from Nov 30, 2017

Conversation

jdee
Copy link
Collaborator

@jdee jdee commented Nov 30, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

/Users/jdee/github/jdee/fastlane/fastlane/lib/fastlane/actions/frameit.rb:4:in `<module:Actions>': uninitialized constant Fastlane::Actions::FrameScreenshotsAction (NameError)

And just above that, in frameit.rb, require 'fastlane/actions/frameit', which is the same file. It's not clear why this didn't fail in CI.

Description

Changed the require to 'fastlane/actions/frame_screenshots'.

Copy link
Contributor

@mpirri mpirri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good find!!! Thanks for fixing that.

@jdee jdee merged commit b3a3ff4 into fastlane:master Nov 30, 2017
@jdee jdee deleted the fix-frameit branch November 30, 2017 02:45
@fastlane-bot
Copy link

Hey @jdee 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@mpirri mpirri mentioned this pull request Nov 30, 2017
@fastlane fastlane locked and limited conversation to collaborators Jan 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants