Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Snapshot record video #11744
Motivation and Context
This change add Snapshot to the ability to record videos of iOS applications, using the same method used to take screenshots.
Added ability to record of video within the simulator
So there's good news and bad news.
Note to project maintainer: This is a terminal state, meaning the
Hey, cool to see some movement in this again. Please make sure to avoid adding a web server to this, as it adds a lot of complexity to the code base. I'm using
Request Change to make sure this doesn't get merged until it's ready, it's still WIP, right?
@KrauseFx any recommendation on how to communicated the UITest with the Fastlane process to start/stop the recording ?
I did used the web server because it was very easy of implement, I also tested to use a flag file, but that was not ok because I did used a 3rd party library to watch for file system changes.
There are a few other options:
I think the
@KrauseFx any thoughts here?
I'd just like to mention that this pull request as it stands doesn't provide any additional functionality as it stands. It's based on PR #10121 I'm not 100% sure about your questions.
However this pull request has the http listener code removed and therefore doesn't have any means of triggering the video recording.
I started this PR at that point, in the hope that someone would step in and advise and contribute to it's completion. I understand that @laullon has moved on from his PR with other projects and doesn't have time to contribute further.
For information purposes, I have created a new branch https://github.com/Jules2010/fastlane/tree/snapshot-record-video-with-audio which includes @laullon initial work and QuickTime Player to also record sound.
I hope this can move forward.
Yes, I got that, saw the other PR as well.
I tried to understand what is already here and see if this is in an optimal state to solve the remaining problem - because I really like the possible functionality here! Using snapshot to record videos of the app would really be an awesome feature.
Maybe @laullon can also take a look at my comments?
@getaaron unfortunately not, I didn’t write the code originally. But I was able to add sound via QuickTime and use ffmpeg to join the audio and video together.
However my code isn’t pretty and has hardcoded paths.
I did mention to @laullon on twitter but he obviously didn’t find the time to help further.