Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract testing instructions in their own Testing.md file #11837

Merged
merged 4 commits into from Feb 14, 2018

Conversation

janpio
Copy link
Member

@janpio janpio commented Feb 14, 2018

Our testing instructions are good and big enough to get their own file now.

@fastlane fastlane deleted a comment from fastlane-bot-helper Feb 14, 2018
@fastlane fastlane deleted a comment from fastlane-bot-helper Feb 14, 2018
Copy link
Collaborator

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I think it's good having a document covering all the testing workflow! 🚀

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is awesome 👍

@janpio janpio merged commit f131ba4 into master Feb 14, 2018
@janpio janpio deleted the janpio-Testing.md branch February 14, 2018 22:06
@fastlane-bot
Copy link

Hey @janpio 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.82.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants