Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix pilot 504ing on build submission for review on testflight #12426
Motivation and Context
We're running into a 504 error that seems related in some way to #11828 when trying to upload and submit a build to our nightly testers group. When the build is submitted for review, the call times out with a 504 but the build manages to get in an approved state. However, because an error is thrown, execution is stopped and pilot never tries to add groups to the build, requiring manual input from a team member to make it happen.
This change is a workaround around the iTunesConnect issue until it gets resolved. I just wanted to put this up for review so that we could discuss if that's a fix that could be made available widely within Fastlane, or to see if we should instead rely on other means such as:
"Clean" options on this issue seem somewhat limited so if you have other ideas I'd love to hear them.
If this change seems reasonable, I can add test coverage!
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed (or fixed any issues), please reply here (e.g.
What to do if you already signed the CLA
@snatchev, I tried adding basic tests and I don't think they necessarily required a fixture for the 504 response, let me know if you think otherwise! Also, I have close to zero experience writing tests in ruby / rspec so let me know if there are shortcuts I could have taken or if the outputs I'm expecting should be better :)
The reason I was asking about the fixture is because I think it could be valuable to have a copy of what a 504 response looks like and is reproducible in test. Especially on intermittent or hard-to-reproduce errors.
I am also a little nervous pinning the entire behavior on the exception string containing the character sequence "504". Is there anything additional we could add? For example checking the exception type?
If you can capture and add a response fixture, I would be happy to help with the spec for it.
@snatchev Sorry for the late reply, was busy and will be for the next week as I'll be travelling. I'll get back to this PR after that.
Also, the worst case scenario of detecting 504 is checking to see if the build's managed to switch states before re-raising the exception if needed, so nothing major there!
May 15, 2018
6 checks passed
Thank you for your contribution to fastlane and congrats on getting this pull request merged
Please let us know if this change requires an immediate release by adding a comment here