New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sigh] support macOS and Developer ID in get_provisioning_profile action #13607

Merged
merged 5 commits into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@mjm
Contributor

mjm commented Oct 29, 2018

馃攽

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

I really want Fastlane to have good support for building macOS apps (#13573). One piece of low-hanging fruit is getting provisioning profiles.

Description

A lot of support is already present in Fastlane for macOS provisioning profiles, so this is mostly a matter of fixing a few issues on the edges. It adds checks on the profile type so that we use the right file extension (.mobileprovision vs. .provisionprofile). It also adds an option to Sigh for Developer ID certificates in addition to the existing types.

I also needed to make a change to the class names for Developer ID certificates in Spaceship: DeveloperID -> DeveloperId. This is to support the automatic class name inference that Spaceship does, so that Spaceship.certificate.developer_id_application maps to the right class, for instance.

With these changes, you can successfully use sigh in Fastlane to get a Developer ID provisioning profile for a macOS app:

get_provisioning_profile(
  developer_id: true,
  platform: 'macos'
)
@googlebot

This comment has been minimized.

googlebot commented Oct 29, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Oct 29, 2018

@mjm

This comment has been minimized.

Contributor

mjm commented Oct 29, 2018

I signed it!

@googlebot

This comment has been minimized.

googlebot commented Oct 29, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 29, 2018

@joshdholtz joshdholtz changed the title from Support macOS and Developer ID in get_provisioning_profile action to [sigh] support macOS and Developer ID in get_provisioning_profile action Nov 2, 2018

@joshdholtz

That is fantastic 馃檶 I'm also down for adding more mac support 馃槉 Thanks for the contribution!

@joshdholtz joshdholtz merged commit 4a8cf2a into fastlane:master Nov 2, 2018

6 checks passed

ci/circleci: Execute tests on Ubuntu Your tests passed on CircleCI!
Details
ci/circleci: Execute tests on macOS Your tests passed on CircleCI!
Details
ci/circleci: Lint Source Code Your tests passed on CircleCI!
Details
ci/circleci: Validate Documentation Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@mjm

This comment has been minimized.

Contributor

mjm commented Nov 2, 2018

Awesome! In that case, expect more PRs around this coming soon!

@joshdholtz

This comment has been minimized.

Contributor

joshdholtz commented Nov 2, 2018

@mjm Looking forward to it 馃槉 馃殌

@mjm mjm deleted the mjm:macos branch Nov 2, 2018

@fastlane-bot

This comment has been minimized.

fastlane-bot commented Nov 2, 2018

Hey @mjm 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

@fastlane-bot

This comment has been minimized.

fastlane-bot commented Nov 5, 2018

Congratulations! 馃帀 This was released as part of fastlane 2.108.0 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment