Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve instructions for using Charles to debug spaceship #13890

Merged
merged 3 commits into from Dec 13, 2018

Conversation

janpio
Copy link
Member

@janpio janpio commented Dec 12, 2018

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

ToolsAndDebugging.md and the spaceship docs had duplicated information and made it harder than necessary for someone to link to one location to instruct people on how to use Charles to create a traffic session.

Description

Move the technical stuff to spaceship, crosslink back from spaceship to the existing Charles instructions. Fix tiny things along the way.

@janpio janpio changed the title [WIP] Improve instructions for using Charles to debug spaceship [docs] Improve instructions for using Charles to debug spaceship Dec 12, 2018
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid 👍

- Download provisioning profiles
- Team selection
- `https://appstoreconnect.apple.com`:
- Managing apps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove those sub-lists on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja, they are already listed on https://github.com/fastlane/fastlane/tree/master/spaceship#api-endpoints where they fit a lot better (although we sure could structure the spaceship docs a bit better as well - future PR)

@janpio janpio merged commit fd5096f into master Dec 13, 2018
@janpio
Copy link
Member Author

janpio commented Dec 13, 2018

🚀

@janpio janpio deleted the janpio-charles_ssl branch December 13, 2018 16:47
@fastlane-bot
Copy link

Hey @janpio 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.111.0 🚀

mariannegru added a commit to mariannegru/fastlane that referenced this pull request Dec 17, 2018
…lect

* origin/master: (38 commits)
  [core] remove leftover launch and completion analytics from UpdateChecker (fastlane#13918)
  [spaceship] Improve Tests for Spaceship::Portal::ProvisioningProfile#factory (fastlane#13909)
  New action ensure_bundle_exec to enforce use of bundler (fastlane#13866)
  Version bump to 2.111.0 (fastlane#13908)
  [match] fix match adhoc RuntimeError error (fastlane#13907)
  [docs] Improve instructions for using Charles to debug spaceship (fastlane#13890)
  [action] Fix Crashlytics deprecated message for submit binary path (fastlane#13854)
  [zip] Handle symbolic links (fastlane#13836)
  [Swift] Fix frameit's Boolean options are generated as String? instead of Bool? (fastlane#13880)
  Address docs feedback by @janpio (fastlane#13898)
  Update Crashlytics action documentation (fastlane#13888)
  Add human-readable storage identifier string to various match outputs (fastlane#13886)
  Add support for `gc_keys.json` file in fastlane subfolder (fastlane#13887)
  Add key information to GC bucket selection (fastlane#13885)
  Add match docs on how to migrate to Google Cloud (fastlane#13884)
  Update match docs to describe Google Cloud Storage (fastlane#13883)
  [deliver] submit for review docs (fastlane#13882)
  Add warning about keys file during match onboarding (fastlane#13881)
  [docs] upload_to_play_store/supply: add link to explanation of version code (fastlane#13872)
  Version bump to 2.110.0 (fastlane#13869)
  ...

# Conflicts:
#	spaceship/README.md
@fastlane fastlane locked and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants