New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve instructions for using Charles to debug spaceship #13890
Conversation
…trial time and the sample command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid 👍
- Download provisioning profiles | ||
- Team selection | ||
- `https://appstoreconnect.apple.com`: | ||
- Managing apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remove those sub-lists on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ja, they are already listed on https://github.com/fastlane/fastlane/tree/master/spaceship#api-endpoints where they fit a lot better (although we sure could structure the spaceship docs a bit better as well - future PR)
🚀 |
Hey @janpio 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.111.0 🚀 |
…lect * origin/master: (38 commits) [core] remove leftover launch and completion analytics from UpdateChecker (fastlane#13918) [spaceship] Improve Tests for Spaceship::Portal::ProvisioningProfile#factory (fastlane#13909) New action ensure_bundle_exec to enforce use of bundler (fastlane#13866) Version bump to 2.111.0 (fastlane#13908) [match] fix match adhoc RuntimeError error (fastlane#13907) [docs] Improve instructions for using Charles to debug spaceship (fastlane#13890) [action] Fix Crashlytics deprecated message for submit binary path (fastlane#13854) [zip] Handle symbolic links (fastlane#13836) [Swift] Fix frameit's Boolean options are generated as String? instead of Bool? (fastlane#13880) Address docs feedback by @janpio (fastlane#13898) Update Crashlytics action documentation (fastlane#13888) Add human-readable storage identifier string to various match outputs (fastlane#13886) Add support for `gc_keys.json` file in fastlane subfolder (fastlane#13887) Add key information to GC bucket selection (fastlane#13885) Add match docs on how to migrate to Google Cloud (fastlane#13884) Update match docs to describe Google Cloud Storage (fastlane#13883) [deliver] submit for review docs (fastlane#13882) Add warning about keys file during match onboarding (fastlane#13881) [docs] upload_to_play_store/supply: add link to explanation of version code (fastlane#13872) Version bump to 2.110.0 (fastlane#13869) ... # Conflicts: # spaceship/README.md
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
ToolsAndDebugging.md and the spaceship docs had duplicated information and made it harder than necessary for someone to link to one location to instruct people on how to use Charles to create a traffic session.
Description
Move the technical stuff to spaceship, crosslink back from spaceship to the existing Charles instructions. Fix tiny things along the way.