Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] Add screenshot dimensions of Apple TV 4K #13939

Merged
merged 1 commit into from Jan 18, 2019

Conversation

janpio
Copy link
Member

@janpio janpio commented Dec 18, 2018

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Currently one can't upload Apple TV 4K screenshots, as reported in #13925.

Description

Adds the size of the 4k screenshots.

fixes #13925

also add a few comments, an resort values
@janpio janpio changed the title [deliver] Add screenshot dimensions of 4K Apple TV [deliver] Add screenshot dimensions of Apple TV 4K Dec 18, 2018
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 @janpio 🙌

@joshdholtz joshdholtz merged commit 030ddb9 into master Jan 18, 2019
@joshdholtz joshdholtz deleted the janpio-4k_apple_tv branch January 18, 2019 05:05
@fastlane-bot
Copy link

Hey @janpio 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.115.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deliver] Can't upload tvOS Apple TV 4k screenshots
4 participants