New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] add missing require #13972

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
5 participants
@slorber
Copy link
Contributor

slorber commented Dec 21, 2018

It seems this fix has been merged into master and released, and for some reason it is not in master anymore.
#13526

missing require
It seems this fix has been merged into master and released, and for some reason it is not in master anymore.
#13526
@janpio

This comment has been minimized.

Copy link
Collaborator

janpio commented Dec 21, 2018

It still is, that PR was just for another file:
https://github.com/fastlane/fastlane/blob/master/deliver/lib/deliver/setup.rb#L1
Your PR is still valid - this file is also using open to download an URI.

@janpio janpio changed the title missing require [deliver] add missing require Dec 21, 2018

@janpio

janpio approved these changes Jan 5, 2019

@janpio janpio merged commit e430ffe into fastlane:master Jan 5, 2019

6 checks passed

ci/circleci: Execute tests on Ubuntu Your tests passed on CircleCI!
Details
ci/circleci: Execute tests on macOS Your tests passed on CircleCI!
Details
ci/circleci: Lint Source Code Your tests passed on CircleCI!
Details
ci/circleci: Validate Documentation Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@fastlane-bot

This comment has been minimized.

Copy link

fastlane-bot commented Jan 5, 2019

Hey @slorber 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot

This comment has been minimized.

Copy link

fastlane-bot commented Jan 8, 2019

Congratulations! 🎉 This was released as part of fastlane 2.113.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment