Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] add symbols and booleans in modify_services action #14215

Merged

Conversation

MartinGonzalez
Copy link
Contributor

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary. Action description updated.

Motivation and Context

This changes allow users to use Symbols & Booleans as parameters in service hash in modify_services_action

Related to: #14202

Description

  • Added Symbols & Booleans as valid parameters in modify_services_action

Previous modify_services example:

    modify_services(
      app_identifier: 'com.company.product',
      team_id: 'A255399',
      services: {
        push_notification: 'on',
        associated_domains: 'off'
      }
    )

Proposed modify_services example (keeping previous example valid):

    modify_services(
      app_identifier: 'com.company.product',
      team_id: 'A255399',
      services: {
        push_notification: :on,
        associated_domains: :off
      }
    )

or

    modify_services(
      app_identifier: 'com.company.product',
      team_id: 'A255399',
      services: {
        push_notification: true,
        associated_domains: false
      }
    )

How did I test it?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@MartinGonzalez
Copy link
Contributor Author

I just signed the CLA

@MartinGonzalez MartinGonzalez mentioned this pull request Feb 9, 2019
4 tasks
@MartinGonzalez MartinGonzalez force-pushed the add-alt-params-modify-service branch 2 times, most recently from 9842a7b to 2799eb8 Compare February 9, 2019 19:51
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small cleanups and a question here! But can we also get some tests added as well? 😊

fastlane/lib/fastlane/actions/modify_services.rb Outdated Show resolved Hide resolved
fastlane/lib/fastlane/actions/modify_services.rb Outdated Show resolved Hide resolved
@joshdholtz joshdholtz changed the title add symbols and booleans in modify_services action [action] add symbols and booleans in modify_services action Feb 14, 2019
Co-Authored-By: MartinGonzalez <gonzalez.martin90@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Co-Authored-By: MartinGonzalez <gonzalez.martin90@gmail.com>
@MartinGonzalez
Copy link
Contributor Author

A few small cleanups and a question here! But can we also get some tests added as well? 😊

I did not create this action, but I would love to do some test. I'm new in fastlane I do not know how to test an action. Should I simple create a double of the action class just like any ruby class?

@joshdholtz
Copy link
Member

@MartinGonzalez I push a commit into your branch that added tests! Hope that's okay 😊

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these additions! It always confused me on why this couldn't be symbols or booleans 😊

@joshdholtz joshdholtz merged commit 3935c59 into fastlane:master Feb 19, 2019
@fastlane-bot
Copy link

Hey @MartinGonzalez 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.116.1 🚀

@fastlane fastlane locked and limited conversation to collaborators Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants