New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] add symbols and booleans in modify_services action #14215
[action] add symbols and booleans in modify_services action #14215
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I just signed the CLA |
9842a7b
to
2799eb8
Compare
2799eb8
to
4856f60
Compare
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small cleanups and a question here! But can we also get some tests added as well? 😊
Co-Authored-By: MartinGonzalez <gonzalez.martin90@gmail.com>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Co-Authored-By: MartinGonzalez <gonzalez.martin90@gmail.com>
I did not create this action, but I would love to do some test. I'm new in fastlane I do not know how to test an action. Should I simple create a double of the action class just like any ruby class? |
@MartinGonzalez I push a commit into your branch that added tests! Hope that's okay 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these additions! It always confused me on why this couldn't be symbols or booleans 😊
Hey @MartinGonzalez 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.116.1 🚀 |
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This changes allow users to use Symbols & Booleans as parameters in
service
hash inmodify_services_action
Related to: #14202
Description
modify_services_action
Previous
modify_services
example:Proposed
modify_services
example (keeping previous example valid):or
How did I test it?