Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] update_app_identifier fails to search for curly brace variables in Info.plist #14687

Conversation

mollyIV
Copy link
Member

@mollyIV mollyIV commented Apr 26, 2019

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The update_app_identifier action does not properly detect all uses of PRODUCT_BUNDLE_IDENTIFIER in the Info.plist file. Older Xcode projects and many examples show curly braces being used for variables inside the Info.plist file like ${PRODUCT_BUNDLE_IDENTIFIER}. update_app_identifier only searches very specifically for parenthesis like $(PRODUCT_BUNDLE_IDENTIFIER) and fails to find the curly brace instance of this variable.

closes #14672

Description

Added the support for curly brackets for product bundle identifier in update_app_identifier action.

Screen Shot 2019-04-26 at 16 01 47

I added the new unit tests and did manual testing.

Screen Shot 2019-04-26 at 16 01 29

I also performed regression tests and all seems to be good 👍

💪

Copy link
Collaborator

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🌵

I wish a utility which treats difference like this....

fastlane/lib/fastlane/actions/update_app_identifier.rb Outdated Show resolved Hide resolved
fastlane/lib/fastlane/actions/update_app_identifier.rb Outdated Show resolved Hide resolved
@mollyIV
Copy link
Member Author

mollyIV commented Apr 26, 2019

Thanks for the review @giginet 🙌

Implemented the requested changes 💪 🙇

Copy link
Collaborator

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@giginet giginet merged commit e442d13 into fastlane:master Apr 26, 2019
@mollyIV mollyIV deleted the fix-action-update-app-identifier-curly-brackets branch April 26, 2019 18:10
@fastlane-bot
Copy link

Hey @mollyIV 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.122.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[action] update_app_identifier fails to search for curly brace variables in Info.plist
4 participants