Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastlane] warn user during load_plugins when failure to find action #15532

Merged
merged 3 commits into from Oct 23, 2019

Conversation

@joshdholtz
Copy link
Member

joshdholtz commented Oct 22, 2019

Fixes #15506
Fixes fastlane-community/fastlane-plugin-firebase_app_distribution#15

And bonus fix for failing CI with Homebrew/brew#6112 (comment)

Motivation and Context

Give users some more help when plugins fail to load without an actions

Description

  • Add a message with a link to new doc that also explains
  • Also added a new optional parameter onto load_plugins to prevent the setting of ENV["FASTLANE_ENV_PRINTER"] which was causing test failures due to the environment variables never being cleared out

Screen Shot 2019-10-22 at 2 54 43 PM

Testing Steps

@joshdholtz joshdholtz requested a review from snatchev Oct 22, 2019
@googlebot googlebot added the cla: yes label Oct 22, 2019
joshdholtz added 2 commits Oct 22, 2019
Copy link
Member

snatchev left a comment

LGTM. Just 1 question about the env var. If its deprecated, isn't there a env var registry somewhere we need to update as well?

@@ -50,11 +50,11 @@ def self.print_date
end

def self.print_loaded_plugins
ENV["FASTLANE_ENV_PRINTER"] = "enabled"

This comment has been minimized.

Copy link
@snatchev

snatchev Oct 23, 2019

Member

Is this env var now deprecated / unused?

This comment has been minimized.

Copy link
@joshdholtz

joshdholtz Oct 23, 2019

Author Member

This ENV var wasn't used by anything external at all 😬 Its only use being used as a parameter of sorts 😔

@joshdholtz joshdholtz merged commit 5b7ad1c into master Oct 23, 2019
9 checks passed
9 checks passed
ci/circleci: Execute modules load up tests Your tests passed on CircleCI!
Details
ci/circleci: Execute tests on Ubuntu Your tests passed on CircleCI!
Details
ci/circleci: Execute tests on macOS (Xcode 11.0.0, Ruby 2.5) Your tests passed on CircleCI!
Details
ci/circleci: Execute tests on macOS (Xcode 9.0.1, Ruby 2.3) Your tests passed on CircleCI!
Details
ci/circleci: Lint Source Code Your tests passed on CircleCI!
Details
ci/circleci: Validate Documentation Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
danger/danger All green. Yay.
@joshdholtz joshdholtz deleted the joshdholtz-load_plugin-warning-when-no-action branch Oct 23, 2019
@fastlane-bot

This comment has been minimized.

Copy link

fastlane-bot commented Oct 23, 2019

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot

This comment has been minimized.

Copy link

fastlane-bot commented Nov 11, 2019

Congratulations! 🎉 This was released as part of fastlane 2.135.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.