[acition] adds 'Apple Distribution' as valid authority when verifying builds #16196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpassis
force-pushed
the
fix-verify-build-certificate-authority
branch
from
00ea8a0
to
b7ab7ae
Compare
joshdholtz
changed the title
joshdholtz
approved these changes
Apr 3, 2020
|
Hey @rpassis 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
reviewed
Apr 5, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.145.0 🚀
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Fixes #16020
verify_buildcommand fails when using the new cross-platform distribution certificates.Description
The current logic in verify build expects the certificate authority to match a regex of
Authority=i(Phone|OS) Distribution.However, the new cross-platform certificates made available by Apple with Xcode 11 have the certificate authority as
Apple Distribution, which does not match the regex and causes validation to fail.This PR addresses the issue by adding
Apple Distributionas a valid authority option during build validation.Note that the implementation of the regex has to use a more specific expression because matching only for
(iOS|iPhone|Apple)will causeApple Root CAandApple Worldwide Certificate Authoritycertificates to be incorrectly identified as a match.