[snapshot] Add override_status_bar option#16419
Merged
Merged
Conversation
This will override the status bar with simctl to show 9:41 AM, and have full battery and reception.
|
Cool MR! What if we can set the date? Instead of hardcoded 9:41? provide parameter with valid date-time string, using well known format? YYYY-MM-DD hh:mm |
janpio
reviewed
May 6, 2020
| UI.message("Overriding Status Bar") | ||
|
|
||
| # The time needs to be passed as ISO8601 so the simulator formats it correctly | ||
| time = Time.new(2007, 1, 9, 9, 41, 0) |
Member
There was a problem hiding this comment.
Making this configurable can be tackled in a future PR <3
janpio
changed the title
janpio
approved these changes
May 6, 2020
janpio
left a comment
janpio
left a comment
Member
There was a problem hiding this comment.
Looks good to me, someone with a Mac handy should test it though :)
joshdholtz
approved these changes
May 12, 2020
joshdholtz
left a comment
joshdholtz
left a comment
Member
There was a problem hiding this comment.
This worked perfectly! Thank you so much for adding this ❤
fastlane-bot
left a comment
fastlane-bot
left a comment
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
minuscorp
pushed a commit
to minuscorp/fastlane
that referenced
this pull request
Jul 18, 2020
* snapshot: Add override_status_bar option This will override the status bar with simctl to show 9:41 AM, and have full battery and reception. * Reformat code for rubocop * Update documentation to reference override_status_bar * Use ISO8601 timestamp so the date is also correct on iPad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
xcode now has a way to override the status bar built-in, so there's no need for SimulatorStatusMagic any more.
Description
This will override the status bar with simctl to show 9:41 AM, and have full battery and reception.
Fixes #15319