From 898998357e4e9953a0e800efda03f6debbee9ee9 Mon Sep 17 00:00:00 2001 From: Addison Brickey Date: Wed, 8 Jul 2020 21:50:57 -0700 Subject: [PATCH 1/2] add shortcuts for getting current pending release and current in review app store version --- .../lib/spaceship/connect_api/models/app.rb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/spaceship/lib/spaceship/connect_api/models/app.rb b/spaceship/lib/spaceship/connect_api/models/app.rb index 2e33a22b8fe..a6f29cf79c3 100644 --- a/spaceship/lib/spaceship/connect_api/models/app.rb +++ b/spaceship/lib/spaceship/connect_api/models/app.rb @@ -181,6 +181,24 @@ def get_edit_app_store_version(platform: nil, includes: nil) .last end + def get_in_review_app_store_version(platform: nil, includes: nil) + platform ||= Spaceship::ConnectAPI::Platform::IOS + filter = { + appStoreState: [Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::IN_REVIEW].join(","), + platform: platform + } + return get_app_store_versions(filter: filter, includes: includes).first + end + + def get_pending_release_app_store_version(platform: nil, includes: nil) + platform ||= Spaceship::ConnectAPI::Platform::IOS + filter = { + appStoreState: [Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::PENDING_DEVELOPER_RELEASE].join(","), + platform: platform + } + return get_app_store_versions(filter: filter, includes: includes).first + end + def get_app_store_versions(filter: {}, includes: nil, limit: nil, sort: nil) resps = Spaceship::ConnectAPI.get_app_store_versions(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages return resps.flat_map(&:to_models) From 256bdf8ff4f46894c0d4ea49d3c48acaae0d3b62 Mon Sep 17 00:00:00 2001 From: Addison Brickey Date: Fri, 10 Jul 2020 13:48:46 -0700 Subject: [PATCH 2/2] remove unneeded arrays and joins in connect api app model --- spaceship/lib/spaceship/connect_api/models/app.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spaceship/lib/spaceship/connect_api/models/app.rb b/spaceship/lib/spaceship/connect_api/models/app.rb index a6f29cf79c3..e655fa18272 100644 --- a/spaceship/lib/spaceship/connect_api/models/app.rb +++ b/spaceship/lib/spaceship/connect_api/models/app.rb @@ -155,7 +155,7 @@ def ensure_version!(version_string, platform: nil) def get_live_app_store_version(platform: nil, includes: nil) platform ||= Spaceship::ConnectAPI::Platform::IOS filter = { - appStoreState: [Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::READY_FOR_SALE].join(","), + appStoreState: Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::READY_FOR_SALE, platform: platform } return get_app_store_versions(filter: filter, includes: includes).first @@ -184,7 +184,7 @@ def get_edit_app_store_version(platform: nil, includes: nil) def get_in_review_app_store_version(platform: nil, includes: nil) platform ||= Spaceship::ConnectAPI::Platform::IOS filter = { - appStoreState: [Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::IN_REVIEW].join(","), + appStoreState: Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::IN_REVIEW, platform: platform } return get_app_store_versions(filter: filter, includes: includes).first @@ -193,7 +193,7 @@ def get_in_review_app_store_version(platform: nil, includes: nil) def get_pending_release_app_store_version(platform: nil, includes: nil) platform ||= Spaceship::ConnectAPI::Platform::IOS filter = { - appStoreState: [Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::PENDING_DEVELOPER_RELEASE].join(","), + appStoreState: Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::PENDING_DEVELOPER_RELEASE, platform: platform } return get_app_store_versions(filter: filter, includes: includes).first