Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update AppStoreConnect.md - replace deprecated Spaceship::Tunes calls #17319

Merged
merged 1 commit into from Sep 28, 2020

Conversation

techinpark
Copy link
Contributor

Motivation and Context

Replace deprecated Spaceship::Tunes calls with Spaceship::ConnectAPI

  • app.live_version to app.get_live_app_store_version
  • app.edit_version to app.get_edit_app_store_version

Description

Simple documentation corrected it by (#17148)

Replace deprecated Spaceship::Tunes calls with Spaceship::ConnectAPI
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@techinpark
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE THIS! Thank you for fixing this ❤️

@joshdholtz joshdholtz changed the title Update AppStoreConnect.md - Replace deprecated Spaceship::Tunes calls [docs] update AppStoreConnect.md - replace deprecated Spaceship::Tunes calls Sep 28, 2020
@joshdholtz joshdholtz merged commit e5e31a8 into fastlane:master Sep 28, 2020
10 checks passed
@fastlane-bot
Copy link

Hey @techinpark 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane fastlane locked and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants