New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[regression][zip] fix the shellescape
for the folder path
#19207
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
@googlebot I consent. |
This fixes the reported problem for me, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃敟 馃敟 Thank you for making this fix!
Congratulations! 馃帀 This was released as part of fastlane 2.191.0 馃殌 |
Thanks for fixing this @crazymanish and sorry for introducing the regression in the first place! I am actually going to submit a followup PR though that ensures that every individual argument is escaped using an approach that I applied for a different PR too (NovatecConsulting/fastlane-plugin-xcodegen#5). It was a stupid mistake as its |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
(
聽#19203:include
and:exclude
config options聽#19149Description
shellescape
for the folder pathTesting Steps
Gemfile
to 馃憞 and runbundle install
,bundle update fastlane
, orbundle update
zip
action using below lanebundle exec fastlane test_zip_fix