Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression][zip] fix the shellescape for the folder path #19207

Merged
merged 5 commits into from Aug 6, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

  • In this PR, fix the shellescape for the folder path

Testing Steps

  • Update Gemfile to 馃憞 and run bundle install, bundle update fastlane, or bundle update
gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "crazymanish-zip-regression-fix"
  • Try to zip action using below lane bundle exec fastlane test_zip_fix
lane :test_zip_fix do
    versioned_bundle_name = "Some-App (1134.2123518)"
    zip(path: "./Build", output_path: "./Build/#{versioned_bundle_name}.xcarchive.zip")
end

@google-cla
Copy link

google-cla bot commented Aug 4, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 4, 2021
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 4, 2021
@rkeniger
Copy link

rkeniger commented Aug 4, 2021

This fixes the reported problem for me, thanks.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃敟 馃敟 Thank you for making this fix!

@joshdholtz joshdholtz merged commit 1b53604 into master Aug 6, 2021
@joshdholtz joshdholtz deleted the crazymanish-zip-regression-fix branch August 6, 2021 01:03
@fastlane-bot
Copy link

Congratulations! 馃帀 This was released as part of fastlane 2.191.0 馃殌

@liamnichols
Copy link
Contributor

Thanks for fixing this @crazymanish and sorry for introducing the regression in the first place!

I am actually going to submit a followup PR though that ensures that every individual argument is escaped using an approach that I applied for a different PR too (NovatecConsulting/fastlane-plugin-xcodegen#5).

It was a stupid mistake as its Actions.sh(*zip_command) vs Actions.sh(zip_command) but I only just spotted it now (and saw that you had already fixed the regression part 鉂わ笍)

@fastlane fastlane locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zip() command fails in 2.190.0 if the path contains characters that require escaping, such as (
5 participants