[spaceship] add update method to ConnectAPI::User - #20956
Merged
Conversation
Contributor
Author
|
@revolter , sorry for the ping, but if there is something I can improve? |
Contributor
Author
|
@joshdholtz , do I have any chances you review this PR馃檹 ? |
Contributor
Author
|
@ainame , @rogerluan , any kind of feedback is appreciated 馃檹 . |
rogerluan
approved these changes
Mar 1, 2023
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
revolter
approved these changes
Mar 9, 2023
revolter
left a comment
Collaborator
There was a problem hiding this comment.
Unfortunately, I don't have experience with this part of the app, so I can't say much (except some nitpicking) 馃槥
All the changes do make sense to me, though, and I trust that you actually tested them 馃挭馃徎
Also, it doesn't look like it could break anything, but I'm not sure, so I'd wait for @joshdholtz to take a look too 馃槦
Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com>
Contributor
Author
|
Any chances of merging this? |
Collaborator
|
I took another look, and, again, it doesn't look like it could break existing logic, it rather adds new logic, so I will merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
We want to have the ability to change user roles and app access. And for that, we need Modify a User Account
API implemented.
Description
updateor describe changes using parameters.UserInvitation.createdocs.User.update&UserInvitation.requestsif all apps are allowed to reduce the number of API errors.Testing Steps