From 797201d7df6cb5cb35c76380543d2cea6ee78ddd Mon Sep 17 00:00:00 2001 From: Kyle Howells Date: Sat, 22 Apr 2023 03:46:41 +0100 Subject: [PATCH 1/3] Add missing newer iPhone models to Generated Snapshot Reports --- snapshot/lib/snapshot/reports_generator.rb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/snapshot/lib/snapshot/reports_generator.rb b/snapshot/lib/snapshot/reports_generator.rb index d65acad9ba3..38ba60c486d 100644 --- a/snapshot/lib/snapshot/reports_generator.rb +++ b/snapshot/lib/snapshot/reports_generator.rb @@ -84,6 +84,11 @@ def xcode_9_and_above_device_name_mappings { # snapshot in Xcode 9 saves screenshots with the SIMULATOR_DEVICE_NAME # which includes spaces + 'iPhone 14 Pro Max' => "iPhone 14 Pro Max", + 'iPhone 14 Pro' => "iPhone 14 Pro", + 'iPhone 14 Plus' => "iPhone 14 Plus", + 'iPhone 14' => "iPhone 14", + 'iPhone SE (3rd generation)' => "iPhone SE (3rd generation)", 'iPhone 13 Pro Max' => "iPhone 13 Pro Max", 'iPhone 13 Pro' => "iPhone 13 Pro", 'iPhone 13 mini' => "iPhone 13 mini", @@ -92,6 +97,7 @@ def xcode_9_and_above_device_name_mappings 'iPhone 12 Pro' => "iPhone 12 Pro", 'iPhone 12 mini' => "iPhone 12 mini", 'iPhone 12' => "iPhone 12", + 'iPhone SE (2nd generation)' => "iPhone SE (2nd generation)", 'iPhone 11 Pro Max' => "iPhone 11 Pro Max", 'iPhone 11 Pro' => "iPhone 11 Pro", 'iPhone 11' => "iPhone 11", From 2f086fb3bb657344114f320f3641d00a2668edd9 Mon Sep 17 00:00:00 2001 From: Kyle Howells Date: Sat, 22 Apr 2023 05:02:11 +0100 Subject: [PATCH 2/3] Add missing iPad versions as well --- snapshot/lib/snapshot/reports_generator.rb | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/snapshot/lib/snapshot/reports_generator.rb b/snapshot/lib/snapshot/reports_generator.rb index 38ba60c486d..72f18fba47d 100644 --- a/snapshot/lib/snapshot/reports_generator.rb +++ b/snapshot/lib/snapshot/reports_generator.rb @@ -118,20 +118,34 @@ def xcode_9_and_above_device_name_mappings 'iPhone SE' => "iPhone SE", 'iPhone 4s' => "iPhone 4s (3.5-Inch)", 'iPad 2' => 'iPad 2', + 'iPad Air (5th generation)' => 'iPad Air (5th generation)', + 'iPad Air (4th generation)' => 'iPad Air (4th generation)', 'iPad Air (3rd generation)' => 'iPad Air (3rd generation)', 'iPad Air 2' => 'iPad Air 2', 'iPad Air' => 'iPad Air', 'iPad (5th generation)' => 'iPad (5th generation)', 'iPad (7th generation)' => 'iPad (7th generation)', + 'iPad (8th generation)' => 'iPad (8th generation)', + 'iPad (9th generation)' => 'iPad (9th generation)', + 'iPad (10th generation)' => 'iPad (10th generation)', 'iPad mini 2' => 'iPad mini 2', 'iPad mini 3' => 'iPad mini 3', 'iPad mini 4' => 'iPad mini 4', + 'iPad mini (5th generation)' => 'iPad mini (5th generation)', 'iPad mini (6th generation)' => 'iPad mini (6th generation)', 'iPad Pro (9.7-inch)' => 'iPad Pro (9.7-inch)', 'iPad Pro (9.7 inch)' => 'iPad Pro (9.7-inch)', # iOS 10.3.1 simulator 'iPad Pro (10.5-inch)' => 'iPad Pro (10.5-inch)', + 'iPad Pro (11-inch) (4th generation) (16GB)' => 'iPad Pro (11-inch) (4th generation) (16GB)', + 'iPad Pro (11-inch) (4th generation)' => 'iPad Pro (11-inch) (4th generation)', + 'iPad Pro (11-inch) (3rd generation)' => 'iPad Pro (11-inch) (3rd generation)', + 'iPad Pro (11-inch) (3rd generation)' => 'iPad Pro (11-inch) (3rd generation)', 'iPad Pro (11-inch) (2nd generation)' => 'iPad Pro (11-inch) (2nd generation)', + 'iPad Pro (11-inch) (1st generation)' => 'iPad Pro (11-inch) (1st generation)', 'iPad Pro (11-inch)' => 'iPad Pro (11-inch)', + 'iPad Pro (12.9-inch) (6th generation) (16GB)' => 'iPad Pro (12.9-inch) (6th generation) (16GB)', + 'iPad Pro (12.9-inch) (6th generation)' => 'iPad Pro (12.9-inch) (6th generation)', + 'iPad Pro (12.9-inch) (5th generation)' => 'iPad Pro (12.9-inch) (5th generation)', 'iPad Pro (12.9-inch) (4th generation)' => 'iPad Pro (12.9-inch) (4th generation)', 'iPad Pro (12.9-inch) (3rd generation)' => 'iPad Pro (12.9-inch) (3rd generation)', 'iPad Pro (12.9-inch) (2nd generation)' => 'iPad Pro (12.9-inch) (2nd generation)', From f85e84a47430018f71339d8fa7efd68f11225709 Mon Sep 17 00:00:00 2001 From: Kyle Howells Date: Sat, 22 Apr 2023 05:23:22 +0100 Subject: [PATCH 3/3] Fix accidental duplicate --- snapshot/lib/snapshot/reports_generator.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/snapshot/lib/snapshot/reports_generator.rb b/snapshot/lib/snapshot/reports_generator.rb index 72f18fba47d..49d45a8f622 100644 --- a/snapshot/lib/snapshot/reports_generator.rb +++ b/snapshot/lib/snapshot/reports_generator.rb @@ -139,7 +139,6 @@ def xcode_9_and_above_device_name_mappings 'iPad Pro (11-inch) (4th generation) (16GB)' => 'iPad Pro (11-inch) (4th generation) (16GB)', 'iPad Pro (11-inch) (4th generation)' => 'iPad Pro (11-inch) (4th generation)', 'iPad Pro (11-inch) (3rd generation)' => 'iPad Pro (11-inch) (3rd generation)', - 'iPad Pro (11-inch) (3rd generation)' => 'iPad Pro (11-inch) (3rd generation)', 'iPad Pro (11-inch) (2nd generation)' => 'iPad Pro (11-inch) (2nd generation)', 'iPad Pro (11-inch) (1st generation)' => 'iPad Pro (11-inch) (1st generation)', 'iPad Pro (11-inch)' => 'iPad Pro (11-inch)',