Skip to content

Adding access token prompt for GitLab Secure Files Match - #21279

Merged
getaaron merged 2 commits into
fastlane:masterfrom
darbyfrey:secure_file_access_token
Jul 3, 2023
Merged

Adding access token prompt for GitLab Secure Files Match#21279
getaaron merged 2 commits into
fastlane:masterfrom
darbyfrey:secure_file_access_token

Conversation

@darbyfrey

@darbyfrey darbyfrey commented May 15, 2023

Copy link
Copy Markdown
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The authentication part of the GitLab Match storage backend can be confusing and the error messages are hard to understand. As reported in: #20525

Description

This change adds better error messaging as well as a prompt to supply the access token when it can't be found.

Xnapper-2023-05-15-14 34 45

Xnapper-2023-05-15-14 27 03

Testing Steps

  1. To render the prompt, run fastlane match with gitlab_secure_files configured as the storage backend.
  2. To render the error, run PRIVATE_TOKEN=foo fastlane match with gitlab_secure_files configured as the storage backend.

@darbyfrey

Copy link
Copy Markdown
Contributor Author

@getaaron I've got another one for you when you have some time, thanks!

@getaaron
getaaron merged commit ba801c7 into fastlane:master Jul 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants