Skip to content

[deliver] Update upload_price_tier - #21282

Merged
joshdholtz merged 1 commit into
fastlane:masterfrom
lukethoene:pricing_tier_fix
May 31, 2023
Merged

[deliver] Update upload_price_tier#21282
joshdholtz merged 1 commit into
fastlane:masterfrom
lukethoene:pricing_tier_fix

Conversation

@lukethoene

Copy link
Copy Markdown
Contributor

Updates Pricing tier selection to correctly handle nil value

Motivation and Context

  • Bug in upload_price_tier.rb resulting in neither pricing nor availability being selected

Resolves #21236

Description

This change adds safe nav operator to prevent NoMethodErrors when checking first app price, preventing failure to set pricing tier for new app listings.

Tested via creation of several new dummy apps to verify the pricing is set as expected.

Testing Steps

  • Create a New App
  • Verify pricing is set as expected

ng tier election to correctly handle nil value
@google-cla

google-cla Bot commented May 16, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lukethoene lukethoene changed the title updates pricing tier [deliver] Update upload_price_tier May 16, 2023
@bartpowers

Copy link
Copy Markdown

馃憤 Works for me with this change

@anh1979

anh1979 commented May 31, 2023

Copy link
Copy Markdown

Please, could anyone let this proceed, then?

@joshdholtz joshdholtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll get a new version out tonight

Thanks for the fix! 鉂わ笍

@joshdholtz
joshdholtz merged commit 0495da3 into fastlane:master May 31, 2023
@vincentisambart

Copy link
Copy Markdown
Contributor

I'm sorry, but as I wrote (#21213 (comment)) in the very similar #21213, I don't think this fix is correct. This will probably end up making any app available in all territories.

iOSGeekster pushed a commit to iOSGeekster/fastlane that referenced this pull request Jun 19, 2023
ng tier election to correctly handle nil value
@pedro380085

Copy link
Copy Markdown

Thank you for releasing this as part of 2.214.0!

@wesselj2

Copy link
Copy Markdown

I can confirm what @vincentisambart is saying. This is setting our apps to be available in all territories every time we submit and we have to manually change it.

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants