Fix fastlane action template warnings reported by Rubocop - #21310
Merged
Conversation
bartoszkosiorek
changed the title
bartoszkosiorek
force-pushed
the
rubocop
branch
2 times, most recently
from
May 30, 2023 09:26
6f515f4 to
945d12c
Compare
Fixes: * Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an unless. * Style/AndOr: Use && instead of and. * Style/Not: Use ! instead of not.
getaaron
approved these changes
Jul 4, 2023
Collaborator
|
Thanks for the PR, @bartoszkosiorek-tomtom ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
When the new default action is created, the rubocop is complaing about wrong code style. The purpose of this PR is to fix the most easy to fix warnings, to improve user experience of end users (less warnings to fix).
Steps to introduce:
Description
With this PR, several trivial warnings were fixed:
Layout/IndentationWidth,Style/StringLiterals,Style/MethodCallWithArgsParentheses,Layout/LineLength,Style/ParenthesesAroundCondition,Style/AndOrandStyle/Not. As a result once developer create default action, it will have less updates to be complient with RuboCop.