Skip to content

[match] Fixes Gitlab Secure Files API limit - #21361

Merged
getaaron merged 1 commit into
fastlane:masterfrom
darbyfrey:fix-gitlab-secure-files-api-limit
Jul 4, 2023
Merged

[match] Fixes Gitlab Secure Files API limit#21361
getaaron merged 1 commit into
fastlane:masterfrom
darbyfrey:fix-gitlab-secure-files-api-limit

Conversation

@darbyfrey

@darbyfrey darbyfrey commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This PR finishes the changes that were started in #21205

Resolves #21204

This change fixes an issue for those people who have many different certs/provision profiles/keys stored on Gitlab in a "Secure files" section. The api used currently by Fastlane does not take into account paging and it's capable of downloading only 20 such files instead of all of them (max 100). This leads to signing issues as some files might be missing.

Description

Testing Steps

@google-cla

google-cla Bot commented Jun 26, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@getaaron
getaaron merged commit 37f2f6c into fastlane:master Jul 4, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[match] Gitlab Secure files API limited to 20 files by default

2 participants