New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added access to build details of iTunes Connect #3641

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Projects
None yet
6 participants
@KrauseFx
Member

KrauseFx commented Mar 9, 2016

This PR adds a way to receive all builds and build trains even if the user doesn't use TestFlight.
Additionally you can now call build.details to get even more build details, in particular the dSYM download URL and information like the original file name, base SDK and more.

Added implementation and tests

@KrauseFx KrauseFx changed the title from [WIP] Added access to build details of iTunes Connect to Added access to build details of iTunes Connect Mar 9, 2016

@armcknight

This comment has been minimized.

Show comment
Hide comment
@armcknight

armcknight Mar 9, 2016

👍 with the caveat that I do plan to transfer the delaunay app to a different account at some point in the next year, not sure if that will break the test or not.

armcknight commented Mar 9, 2016

👍 with the caveat that I do plan to transfer the delaunay app to a different account at some point in the next year, not sure if that will break the test or not.

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Mar 9, 2016

Member

@armcknight don't worry, all tests are 100% mocked locally 👍

Member

KrauseFx commented Mar 9, 2016

@armcknight don't worry, all tests are 100% mocked locally 👍

@@ -574,6 +574,22 @@ def remove_testflight_build_from_review!(app_id: nil, train: nil, build_number:
handle_itc_response(r.body)
end
# All build trains, even if there is no TestFlight
def all_build_trains(app_id: nil)
r = request(:get, "ra/apps/#{app_id}/buildHistory?platform=ios")

This comment has been minimized.

@lacostej

lacostej Mar 9, 2016

Contributor

is this an ios specific feature ?

@lacostej

lacostej Mar 9, 2016

Contributor

is this an ios specific feature ?

This comment has been minimized.

@KrauseFx

KrauseFx Mar 9, 2016

Member

I honestly don't know, haven't had time to look into this yet

@KrauseFx

KrauseFx Mar 9, 2016

Member

I honestly don't know, haven't had time to look into this yet

@asfalcone

This comment has been minimized.

Show comment
Hide comment
@asfalcone

asfalcone Mar 9, 2016

Contributor

LGTM, left 2 small comments. 👍

Contributor

asfalcone commented Mar 9, 2016

LGTM, left 2 small comments. 👍

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Mar 9, 2016

Member

Squashed commits

Member

KrauseFx commented Mar 9, 2016

Squashed commits

@fastlane-danger-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-danger-bot

fastlane-danger-bot Mar 9, 2016

1 Warning
⚠️ Big PR

Generated by 🚫 danger

fastlane-danger-bot commented Mar 9, 2016

1 Warning
⚠️ Big PR

Generated by 🚫 danger

KrauseFx added a commit that referenced this pull request Mar 9, 2016

Merge pull request #3641 from fastlane/build-details
Added access to build details of iTunes Connect

@KrauseFx KrauseFx merged commit c34f2aa into master Mar 9, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound 7 violations found.
attr_accessor :apple_id
# @return (String) Link to the dSYM file (not always available)
# lol, it's unencrypted http

This comment has been minimized.

@lacostej

lacostej Mar 9, 2016

Contributor

¯_(ツ)_/¯

@lacostej

lacostej Mar 9, 2016

Contributor

¯_(ツ)_/¯

module Tunes
# Represents the details of a build
class BuildDetails < TunesBase
# @return (String) The App identifier of this app, provided by iTunes Connect

This comment has been minimized.

@lacostej

lacostej Mar 9, 2016

Contributor

@return [String]

(no rubocop for that ?)

@lacostej

lacostej Mar 9, 2016

Contributor

@return [String]

(no rubocop for that ?)

attr_accessor :number_of_asset_packs
# @return [Bool]
attr_accessor :contains_odr

This comment has been minimized.

@lacostej

lacostej Mar 9, 2016

Contributor

Mostly a comment: I was wondering what ODR was and this is what I found:

@lacostej

lacostej Mar 9, 2016

Contributor

Mostly a comment: I was wondering what ODR was and this is what I found:

This comment has been minimized.

@KrauseFx

KrauseFx Mar 9, 2016

Member

I don't know what this is, how would you describe this value? It's been false for my apps.

@KrauseFx

KrauseFx Mar 9, 2016

Member

I don't know what this is, how would you describe this value? It's been false for my apps.

This comment has been minimized.

@lacostej

lacostej Mar 9, 2016

Contributor

ODR might also mean: https://developer.apple.com/library/prerelease/ios/documentation/FileManagement/Conceptual/On_Demand_Resources_Guide/

So not really sure what they meant.

It would be interesting to see when it becomes true

@lacostej

lacostej Mar 9, 2016

Contributor

ODR might also mean: https://developer.apple.com/library/prerelease/ios/documentation/FileManagement/Conceptual/On_Demand_Resources_Guide/

So not really sure what they meant.

It would be interesting to see when it becomes true

This comment has been minimized.

@jcampbell05

jcampbell05 Mar 9, 2016

Contributor

I think for when you use on demand resources i.e for levels. So iOS can download it when you indicate when you need it.

@jcampbell05

jcampbell05 Mar 9, 2016

Contributor

I think for when you use on demand resources i.e for levels. So iOS can download it when you indicate when you need it.

This comment has been minimized.

@KrauseFx

KrauseFx Mar 10, 2016

Member

That sounds about right

@KrauseFx

KrauseFx Mar 10, 2016

Member

That sounds about right

@KrauseFx KrauseFx deleted the build-details branch Mar 10, 2016

@fastlane fastlane locked and limited conversation to collaborators Feb 4, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.