Issue with screengrab looking for images in the wrong folder #4915
Conversation
Screengrab creates an additional folder screengrab on emulator/device and this line does not handle this folder.
Generated by |
Hi @sirkro - thanks for the contribution Can you confirm what version of The gem version can be confirmed with:
And the AAR version can be confirmed from your Thanks! |
Hi @mfurtak ,
|
@sirkro This is odd... when I check out your branch and try it locally, it produces an error for me.
Can you please do a run of |
With my fix:
Without fix:
|
it seems that I've the same issue. screenshots are located here |
can this be merged please? I'm facing the same problem and this change helped me. |
Hi all - I would very much like to solve this problem. I do believe that this change is fixing a problem for you all, but the reason I can't merge this yet is that the current code works on my system, but this patch does not. So far I have not been able to figure out the reason for this difference. When
I wind up with a path in my project like:
It seems like you all wind up with a path like:
Does anyone have any ideas on why this difference should occur? I am using
Is anyone using a different version, or an alternative Thank you for your help! |
I found the problem, looking at the adb code in line 994 is says:
So the problem occurs if the folder If you check the git history, this change is there since Mine is:
In my opinion the implementation is wrong there for |
@EarlOfEgo Wow, that is some great investigating! Knowing that, I can ensure the correct behavior by simply ensuring that the output directory exists before doing the Because |
Hi folks - thanks very much for your patience and efforts at fixing this! Based on the new info from @EarlOfEgo, I have tried to address this with #5559. If you have a moment to give that latest code (from master) a try and let me know if it works for you, I can get a new release out quickly! Thanks |
Hi, I think the fix from #5559 doesn't solve the problem. Newer versions of If you want to keep the old path(without |
@EarlOfEgo Confirmed, I'll try again. |
OK, I've given this another shot with a different approach! If folks have time to try this from master, that'd be awesome |
Just checked, works now as intended. Doesn't matter if the directory exists or not the output path is always: |
Great! I'll close this for now, and work on a release. Thanks again to everyone for advocating for the problem and proposing solutions! |
Screengrab creates an additional folder screengrab on emulator/device and this line does not handle this folder.