New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #9353

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
6 participants
@rikusouda
Contributor

rikusouda commented Jun 3, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Keeping the code clean

Description

fix typo

@googlebot

This comment has been minimized.

googlebot commented Jun 3, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label Jun 3, 2017

@rikusouda

This comment has been minimized.

Contributor

rikusouda commented Jun 3, 2017

I signed it!

@googlebot

This comment has been minimized.

googlebot commented Jun 3, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 3, 2017

@KrauseFx KrauseFx changed the title from fix typo to Fix typo Jun 4, 2017

@giginet

giginet approved these changes Jun 6, 2017

@giginet

This comment has been minimized.

Member

giginet commented Jun 6, 2017

@rikusouda Thanks!

@giginet giginet merged commit d1903b0 into fastlane:master Jun 6, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@fastlane-bot

This comment has been minimized.

fastlane-bot commented Jun 6, 2017

Hey @rikusouda 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@rikusouda

This comment has been minimized.

Contributor

rikusouda commented Jun 6, 2017

@giginet Thanks!

@KrauseFx KrauseFx referenced this pull request Jun 12, 2017

Merged

Version bump to 2.38.0 #9439

davidchristiandy added a commit to davidchristiandy/fastlane that referenced this pull request Sep 5, 2017

@fastlane fastlane locked and limited conversation to collaborators Sep 5, 2017

@nafu

This comment has been minimized.

Member

nafu commented Sep 19, 2017

Thanks 🎶 @rikusouda

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.