New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spaceship debugging documentation #9943

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
4 participants
@nafu
Member

nafu commented Aug 3, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Some parts of documentation for debugging spaceship is a little bit old.

Description

  • Update sample commands for debugging
  • Update Rakefile path
  • Replace FASTLANE_DEBUG with SPACESHIP_DEBUG because FASTLANE_DEBUG isn't used in fastlane codebase and I think it is intended to use SPACESHIP_DEBUG instead.

@googlebot googlebot added the cla: yes label Aug 3, 2017

@ohayon

ohayon approved these changes Aug 3, 2017

Thanks @nafu !! 🚀

@ohayon ohayon merged commit d7280e4 into fastlane:master Aug 3, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

@nafu nafu deleted the nafu:update-debugging-document branch Aug 3, 2017

@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Aug 4, 2017

Hey @nafu 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot commented Aug 4, 2017

Hey @nafu 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Aug 8, 2017

Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀

fastlane-bot commented Aug 8, 2017

Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀

davidchristiandy added a commit to davidchristiandy/fastlane that referenced this pull request Sep 5, 2017

@fastlane fastlane locked and limited conversation to collaborators Oct 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.