Support multiple profiles via [profiles] configuration
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/profiles
branch
from
9c959eb
to
6d6a54a
Compare
Integralist
force-pushed
the
integralist/profiles
branch
from
6d6a54a
to
c44832a
Compare
Integralist
commented
Apr 1, 2022
There was a problem hiding this comment.
@doramatadora There are a lot of scenarios to cover and so I've tried to use screenshots in the PR description to help visualise the features this PR is introducing. Otherwise hopefully the following comments help to digest the relevant code changes.
+ update metadata.json + update any fastly configure references
kailan
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
This is not a code review but I have tested the functionality and it works as described. Really excited to see this, thanks for the awesome work @Integralist! 🎉
doramatadora
approved these changes
Apr 4, 2022
Co-authored-by: Dora Militaru <hello@doramilitaru.com>
Co-authored-by: Dora Militaru <hello@doramilitaru.com>
Integralist
force-pushed
the
integralist/profiles
branch
from
623fa7f
to
49a0d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
This PR introduces breaking changes, which will result in a new major version release (
v2.0.0).This PR replaces the
fastly configurecommand with:fastly configfastly profileMigrating existing user data
The configuration file was previously defined as:
The data in these fields will be auto-migrated to a generic 'user' profile:
Screenshots of new commands
Screenshots of usage
The following screenshots do not capture all scenarios or use cases, for that refer to the code and test suite.
List profiles so we can see there are none defined yet...
Create a profile for the first time, it will automatically be set to being the 'default' profile...
Create a new profile, and set it to be the default...
List profiles so we can be sure the new 'personal' profile created has been set to be the default...
Switching profiles, and then checking the profile was switched...
Delete the profile that is currently the 'default', notice the warning provided...
Update a profile but give an unknown profile name...
Update a profile, and also set it to be the default...
Use the global
--profileflag to temporarily switch profiles, but notice we provide an unrecognised profile name...