-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple profiles via [profiles]
configuration
#546
Conversation
9c959eb
to
6d6a54a
Compare
6d6a54a
to
c44832a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doramatadora There are a lot of scenarios to cover and so I've tried to use screenshots in the PR description to help visualise the features this PR is introducing. Otherwise hopefully the following comments help to digest the relevant code changes.
+ update metadata.json + update any fastly configure references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a code review but I have tested the functionality and it works as described. Really excited to see this, thanks for the awesome work @Integralist! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very exciting to see ❤️ 🚀
Co-authored-by: Dora Militaru <hello@doramilitaru.com>
Co-authored-by: Dora Militaru <hello@doramilitaru.com>
623fa7f
to
49a0d30
Compare
Fixes #142
This PR introduces breaking changes, which will result in a new major version release (
v2.0.0
).This PR replaces the
fastly configure
command with:fastly config
fastly profile
Migrating existing user data
The configuration file was previously defined as:
The data in these fields will be auto-migrated to a generic 'user' profile:
Screenshots of new commands
Screenshots of usage
The following screenshots do not capture all scenarios or use cases, for that refer to the code and test suite.
List profiles so we can see there are none defined yet...
Create a profile for the first time, it will automatically be set to being the 'default' profile...
Create a new profile, and set it to be the default...
List profiles so we can be sure the new 'personal' profile created has been set to be the default...
Switching profiles, and then checking the profile was switched...
Delete the profile that is currently the 'default', notice the warning provided...
Update a profile but give an unknown profile name...
Update a profile, and also set it to be the default...
Use the global
--profile
flag to temporarily switch profiles, but notice we provide an unrecognised profile name...