Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version check #589

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fix version check #589

merged 1 commit into from
Jun 29, 2022

Conversation

06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Jun 29, 2022 •
edited

Fixing a failure I introduced

Not sure if this is the best way to have this test without exactly re-implementing the revision.go stuff

cc @Integralist

Integralist
Integralist approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks OK to me.

@Integralist Integralist added the bug Something isn't working label Jun 29, 2022
@Integralist Integralist merged commit 5b0d8ee into fastly:main Jun 29, 2022
@06kellyjac 06kellyjac deleted the fix-tests branch June 29, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @Integralist