use default context instead of setting specific one #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psbanka
approved these changes
Aug 29, 2018
There was a problem hiding this comment.
Okay, the ssl.PROTOCOL_TLS version works fine in python 3.6.5, but your version using ssl.create_default_context() produces the same output, is potentially more secure, and is simpler. I did not try to reproduce your error on Python 3.4, but I'll take your word for it that this solves your error. Thanks for the bug report and the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
I found that using the default context creation tool from
sslactually solved my issue so I decided to open this PR. According to the official python docs, this is what the method does:The tests passed fine on my local branch, but I'm not 100% sure the tests are good enough. Open to suggestions re. better testing of this.