Add tokens.rb #150
Add tokens.rb #150
Conversation
malachy-mcconnell
force-pushed
the
CL-40641
branch
from
90a5875
to
7a870b6
Compare
There was a problem hiding this comment.
Hi @malachy-mcconnell thanks so much for opening this Pull Request. I especially thank you for writing comprehensive tests for the Tokens behavior that you've added.
Do you think you could refactor the implementation a bit to allow for per-request overrides of the auth headers instead of adding additional global state?
There was a problem hiding this comment.
Thanks for your persistence with this PR @malachy-mcconnell. Just a couple of changes and we'll get this merged and released for you ASAP.
There was a problem hiding this comment.
This looks good. Anymore changes you want to make @malachy-mcconnell ?
|
Oh, hi, Are you West Coast? I'm finished making changes. I was just waiting here to see if the tests ran green. |
|
This is released as v2.5.0. Thank you very much for your PR and for your patience! Please let us know if you have any trouble with the release. |
A class file for token objects. Includes amendments to
client.rbfor authentication when creating new tokens.