Fix new_token() and remove session auth from client #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important change is to remove the lines
from
token.rb::new_token()
because client never needs nor wants to know username and password now that session auth is deprecated.We may as well remove all the session references from client as they can no longer have any effect.
Note that new_token needs to be called like this, for example
Which is as expected given the docs example: https://developer.fastly.com/reference/api/auth/#create-token