Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Fastly::Dictionary#item #89

Merged
merged 4 commits into from Jun 17, 2016
Merged

add Fastly::Dictionary#item #89

merged 4 commits into from Jun 17, 2016

Conversation

lanej
Copy link
Contributor

@lanej lanej commented Jun 16, 2016

Returns a specific Fastly::DictionaryItem

@@ -15,7 +18,7 @@ def initialize(opts)
@customer = opts.fetch(:customer, nil)
@oldpurge = opts.fetch(:use_old_purge_method, false)

base = opts.fetch(:base_url, 'https://api.fastly.com')
base = opts.fetch(:base_url, DEFAULT_URL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@blithe
Copy link
Contributor

blithe commented Jun 16, 2016

👍

let(:dictionary) { Fastly::Dictionary.new({id: SecureRandom.hex(6), service_id: service_id, version: 1}, client) }

before {
stub_request(:post, "#{Fastly::Client::DEFAULT_URL}/login").to_return(body: '{}', status: 200, headers: { 'Set-Cookie' => 'tasty!' })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeroll.

@blithe blithe merged commit 99068ea into master Jun 17, 2016
@blithe blithe deleted the add-get-dictionary-item branch June 17, 2016 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants