Skip to content

[bugfix]修复bug #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

[bugfix]修复bug #330

merged 1 commit into from
Oct 22, 2020

Conversation

@pptt168
Copy link
Contributor

@pptt168 pptt168 commented Oct 21, 2020 •
edited
Loading

Description：MLP的小bug

Main reason: 使用MLP([], activation=lambda x: x)出现错误

Checklist 检查下面各项是否完成

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$bugfix] (例如[bugfix]修复bug，[new]添加新功能，[test]修改测试，[rm]删除旧代码)
  • Changes are complete (i.e. I finished coding on this PR) 修改完成才提PR
  • All changes have test coverage 修改的部分顺利通过测试。对于fastnlp/fastnlp/的修改，测试代码必须提供在fastnlp/test/。
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change 修改导致例子或tutorial有变化，请找核心开发人员

Changes: 逐项描述修改的内容

Mention: 找人review你的PR

@修改过这个文件的人
@核心开发人员

@yhcc yhcc merged commit 81bcb51 into fastnlp:master Oct 22, 2020
yhcc pushed a commit that referenced this pull request Oct 25, 2020
@Gosicfly @yhcc
Update vocabulary.py (#325)
9a9732a 
strip只需要将\n去掉，否则会将一些特殊字符去掉，造成split的时候长度出错

token_type_id_rev (#329)

当activation=lambda x: x出现错误 (#330)

Co-authored-by: 路人咦 <1417954729@qq.com>

1.修改部分文档中的typo; 2.支持对transformers embedding

update import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yhcc yhcc yhcc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pptt168 @yhcc @wanggang255