From a8404b16894e5b3efc7f87b06d4adad450901055 Mon Sep 17 00:00:00 2001 From: John Jeong Date: Fri, 4 Jul 2025 12:59:41 -0700 Subject: [PATCH 1/2] feat(listen-button): remove consent reminder timeout Removes the consent reminder timeout functionality from the listen button component. This change simplifies the component and removes unnecessary complexity. The consent notification is now displayed indefinitely until the user takes action. --- .../editor-area/note-header/listen-button.tsx | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/apps/desktop/src/components/editor-area/note-header/listen-button.tsx b/apps/desktop/src/components/editor-area/note-header/listen-button.tsx index b91cefd69..037aa3cce 100644 --- a/apps/desktop/src/components/editor-area/note-header/listen-button.tsx +++ b/apps/desktop/src/components/editor-area/note-header/listen-button.tsx @@ -17,8 +17,6 @@ import { cn } from "@hypr/ui/lib/utils"; import { useOngoingSession, useSession } from "@hypr/utils/contexts"; import ShinyButton from "./shiny-button"; -let consentReminderTimeoutId: NodeJS.Timeout | null = null; - const showConsentNotification = () => { toast({ id: "recording-consent-reminder", @@ -32,21 +30,8 @@ const showConsentNotification = () => { }, primary: true, }, - { - label: "Remind me in 30s", - onClick: () => { - if (consentReminderTimeoutId) { - clearTimeout(consentReminderTimeoutId); - } - consentReminderTimeoutId = setTimeout(() => { - showConsentNotification(); - consentReminderTimeoutId = null; - }, 30000); - }, - }, ], - dismissible: true, - duration: 15000, + dismissible: false, }); }; From e521006e2482ff4805c6eeca4cb693897586c347 Mon Sep 17 00:00:00 2001 From: John Jeong Date: Fri, 4 Jul 2025 12:59:46 -0700 Subject: [PATCH 2/2] i18n --- apps/desktop/src/locales/en/messages.po | 14 +++++++------- apps/desktop/src/locales/ko/messages.po | 14 +++++++------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/apps/desktop/src/locales/en/messages.po b/apps/desktop/src/locales/en/messages.po index 90d8fcbf1..4940c19df 100644 --- a/apps/desktop/src/locales/en/messages.po +++ b/apps/desktop/src/locales/en/messages.po @@ -256,8 +256,8 @@ msgstr "(Beta) Upcoming meeting notifications" #. placeholder {0}: disabled ? "Wait..." : isHovered ? "Resume" : "Ended" #: src/components/settings/components/calendar/cloud-calendar-integration-details.tsx:36 #: src/components/settings/components/ai/wer-modal.tsx:116 -#: src/components/editor-area/note-header/listen-button.tsx:191 -#: src/components/editor-area/note-header/listen-button.tsx:230 +#: src/components/editor-area/note-header/listen-button.tsx:176 +#: src/components/editor-area/note-header/listen-button.tsx:215 msgid "{0}" msgstr "{0}" @@ -881,7 +881,7 @@ msgstr "Optional for participant suggestions" msgid "Owner" msgstr "Owner" -#: src/components/editor-area/note-header/listen-button.tsx:317 +#: src/components/editor-area/note-header/listen-button.tsx:302 msgid "Pause" msgstr "Pause" @@ -893,7 +893,7 @@ msgstr "people" msgid "Performance difference between languages" msgstr "Performance difference between languages" -#: src/components/editor-area/note-header/listen-button.tsx:210 +#: src/components/editor-area/note-header/listen-button.tsx:195 msgid "Play video" msgstr "Play video" @@ -937,7 +937,7 @@ msgstr "Required to transcribe other people's voice during meetings" msgid "Required to transcribe your voice during meetings" msgstr "Required to transcribe your voice during meetings" -#: src/components/editor-area/note-header/listen-button.tsx:119 +#: src/components/editor-area/note-header/listen-button.tsx:104 msgid "Resume" msgstr "Resume" @@ -1035,11 +1035,11 @@ msgstr "Start Annual Plan" msgid "Start Monthly Plan" msgstr "Start Monthly Plan" -#: src/components/editor-area/note-header/listen-button.tsx:166 +#: src/components/editor-area/note-header/listen-button.tsx:151 msgid "Start recording" msgstr "Start recording" -#: src/components/editor-area/note-header/listen-button.tsx:325 +#: src/components/editor-area/note-header/listen-button.tsx:310 msgid "Stop" msgstr "Stop" diff --git a/apps/desktop/src/locales/ko/messages.po b/apps/desktop/src/locales/ko/messages.po index da4fb075a..6d97881be 100644 --- a/apps/desktop/src/locales/ko/messages.po +++ b/apps/desktop/src/locales/ko/messages.po @@ -256,8 +256,8 @@ msgstr "" #. placeholder {0}: disabled ? "Wait..." : isHovered ? "Resume" : "Ended" #: src/components/settings/components/calendar/cloud-calendar-integration-details.tsx:36 #: src/components/settings/components/ai/wer-modal.tsx:116 -#: src/components/editor-area/note-header/listen-button.tsx:191 -#: src/components/editor-area/note-header/listen-button.tsx:230 +#: src/components/editor-area/note-header/listen-button.tsx:176 +#: src/components/editor-area/note-header/listen-button.tsx:215 msgid "{0}" msgstr "" @@ -881,7 +881,7 @@ msgstr "" msgid "Owner" msgstr "" -#: src/components/editor-area/note-header/listen-button.tsx:317 +#: src/components/editor-area/note-header/listen-button.tsx:302 msgid "Pause" msgstr "" @@ -893,7 +893,7 @@ msgstr "" msgid "Performance difference between languages" msgstr "" -#: src/components/editor-area/note-header/listen-button.tsx:210 +#: src/components/editor-area/note-header/listen-button.tsx:195 msgid "Play video" msgstr "" @@ -937,7 +937,7 @@ msgstr "" msgid "Required to transcribe your voice during meetings" msgstr "" -#: src/components/editor-area/note-header/listen-button.tsx:119 +#: src/components/editor-area/note-header/listen-button.tsx:104 msgid "Resume" msgstr "" @@ -1035,11 +1035,11 @@ msgstr "" msgid "Start Monthly Plan" msgstr "" -#: src/components/editor-area/note-header/listen-button.tsx:166 +#: src/components/editor-area/note-header/listen-button.tsx:151 msgid "Start recording" msgstr "" -#: src/components/editor-area/note-header/listen-button.tsx:325 +#: src/components/editor-area/note-header/listen-button.tsx:310 msgid "Stop" msgstr ""