Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 23, 2025

Standardize artifact naming with architecture info

Summary

Addresses inconsistent file naming in the desktop_cd workflow by standardizing artifact names to include OS and architecture information:

  • macOS: hyprnote.dmghyprnote-macos-aarch64.dmg
  • Linux: hyprnote.AppImagehyprnote-linux-x86_64.AppImage

This naming scheme:

  • Provides consistency across release (stable/nightly) and staging builds
  • Includes architecture information for clarity and future-proofing
  • Aligns with Crabnebula's platform naming conventions (dmg-aarch64, appimage-x86_64)

Also adds Linux download support to the web app's changelog pages.

Review & Testing Checklist for Human

  • Verify all 6 filename references in desktop_cd.yaml are consistent - Check S3 upload paths (lines 147-149, 227-229), S3 download paths (lines 262-263, 273-274), and GitHub release artifacts (lines 292, 300)
  • Test web app download links - After next release, verify that changelog pages correctly link to the new filenames on GitHub releases
  • Consider backward compatibility - Existing GitHub releases still have old filenames (hyprnote.dmg, hyprnote.AppImage). The web app now expects new filenames, so old changelog pages may have broken download links unless we backfill or handle this gracefully
  • Verify staging artifacts still work - Staging uses wildcards (*.dmg, *.AppImage) in upload-artifact paths, so should be unaffected, but worth confirming
  • Check for external references - Search for any documentation, scripts, or external tools that might reference the old filenames

Test Plan

  1. Trigger a staging build and verify artifacts are uploaded correctly
  2. After merging, trigger a nightly or stable release
  3. Verify S3 uploads succeed with new filenames
  4. Verify GitHub release has correctly named artifacts
  5. Check that web app changelog page shows working download links

Notes

  • Staging artifact names in the workflow (lines 158, 238) still use the old pattern (hyprnote-staging-macos, hyprnote-staging-linux) but this is just the GitHub Actions artifact name, not the actual filename, so it's low risk
  • The VersionPlatform type was updated to include "appimage-x86_64" to support Linux downloads in the web app
  • This is a breaking change for any external systems that expect the old filenames, though I only found one internal reference which was updated

Session: https://app.devin.ai/sessions/c0fe4648b75f4001bf05130b899f9647
Requested by: yujonglee (@yujonglee)

- Update desktop_cd workflow to use consistent naming:
  - macOS: hyprnote-macos-aarch64.dmg
  - Linux: hyprnote-linux-x86_64.AppImage
- Update S3 paths and GitHub release artifacts
- Add Linux download support to web app
- Update VersionPlatform type to include appimage-x86_64

This provides consistency across release and staging builds,
includes architecture information for clarity, and aligns with
Crabnebula's platform naming conventions.

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Nov 23, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 034f865
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6922d3db34decd0009ebe7d6
😎 Deploy Preview https://deploy-preview-1811--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1763889778-consistent-file-naming

Comment @coderabbitai help to get the list of available commands and usage tips.

@yujonglee yujonglee merged commit 67933cc into main Nov 23, 2025
7 checks passed
@yujonglee yujonglee deleted the devin/1763889778-consistent-file-naming branch November 23, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants