From f6f11c36473048c3a206d6e7ce107c110c13a52e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20V=C3=A1squez?= Date: Fri, 10 Jul 2026 00:03:36 -0600 Subject: [PATCH] Remove unused font-awesome-rails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit font-awesome-rails was pulled in solely by a bare `@import "font-awesome"` in pdf.scss, but no icon is ever rendered: no fa- classes, no fa_icon, no FA glyphs in any view or stylesheet. It imported the entire Font Awesome CSS plus its webfonts (fontawesome-webfont.woff/ttf/svg) into the PDF bundle for zero visible benefit. The fastruby-styleguide gem does not use it either (it uses Material Icons); font-awesome-rails is a direct-only dependency. Dropped the gem and the pdf.scss import; both lockfiles updated. Verified locally: assets:precompile compiles pdf.css with no fontawesome webfonts emitted, unit tests 16/52/0, rubocop + reek clean, and the system test (upload -> results -> PDF download) passes in headless Chrome — the PDF still renders. --- Gemfile | 1 - Gemfile.lock | 3 --- Gemfile.next.lock | 3 --- app/assets/stylesheets/pdf.scss | 3 --- 4 files changed, 10 deletions(-) diff --git a/Gemfile b/Gemfile index 91f8546..7929ac8 100644 --- a/Gemfile +++ b/Gemfile @@ -37,7 +37,6 @@ gem "puma", "~> 8.0" gem "minitest", "< 6" gem "nokogiri", ">= 1.13.0" gem "sass-rails", "~> 6.0" -gem "font-awesome-rails", ">= 4.7.0.9" gem "terser" gem "redcarpet" diff --git a/Gemfile.lock b/Gemfile.lock index dd9ad73..25fe8ae 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -174,8 +174,6 @@ GEM erubi (1.13.1) execjs (2.10.1) ffi (1.17.4) - font-awesome-rails (4.7.0.9) - railties (>= 3.2, < 9.0) globalid (1.4.0) activesupport (>= 6.1) i18n (1.15.2) @@ -430,7 +428,6 @@ DEPENDENCIES concurrent-ruby (>= 1.3.7) dotenv-rails fastruby-styleguide! - font-awesome-rails (>= 4.7.0.9) kt-paperclip (~> 8.0.0) listen (>= 3.5) minitest (< 6) diff --git a/Gemfile.next.lock b/Gemfile.next.lock index dd9ad73..25fe8ae 100644 --- a/Gemfile.next.lock +++ b/Gemfile.next.lock @@ -174,8 +174,6 @@ GEM erubi (1.13.1) execjs (2.10.1) ffi (1.17.4) - font-awesome-rails (4.7.0.9) - railties (>= 3.2, < 9.0) globalid (1.4.0) activesupport (>= 6.1) i18n (1.15.2) @@ -430,7 +428,6 @@ DEPENDENCIES concurrent-ruby (>= 1.3.7) dotenv-rails fastruby-styleguide! - font-awesome-rails (>= 4.7.0.9) kt-paperclip (~> 8.0.0) listen (>= 3.5) minitest (< 6) diff --git a/app/assets/stylesheets/pdf.scss b/app/assets/stylesheets/pdf.scss index efb0707..f2aaac8 100644 --- a/app/assets/stylesheets/pdf.scss +++ b/app/assets/stylesheets/pdf.scss @@ -1,6 +1,3 @@ -// 0-font awesome -@import "font-awesome"; - // 1-styleguide @import "fastruby/styleguide";