From ebc4c097c8c428f9be38f58109e25c574efd92b9 Mon Sep 17 00:00:00 2001 From: Grzegorz Jakubiak Date: Wed, 19 Feb 2020 21:18:34 +0100 Subject: [PATCH] Use sum directly --- lib/skunk/cli/commands/status_reporter.rb | 4 ++-- lib/skunk/rubycritic/analysed_modules_collection.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/skunk/cli/commands/status_reporter.rb b/lib/skunk/cli/commands/status_reporter.rb index 53250a8..2bd1906 100644 --- a/lib/skunk/cli/commands/status_reporter.rb +++ b/lib/skunk/cli/commands/status_reporter.rb @@ -54,11 +54,11 @@ def sorted_modules end def total_stink_score - @total_stink_score ||= non_test_modules.map(&:stink_score).inject(0.0, :+) + @total_stink_score ||= non_test_modules.sum(&:stink_score) end def total_churn_times_cost - non_test_modules.map(&:churn_times_cost).sum + non_test_modules.sum(&:churn_times_cost) end def stink_score_average diff --git a/lib/skunk/rubycritic/analysed_modules_collection.rb b/lib/skunk/rubycritic/analysed_modules_collection.rb index 76a62e4..3f020e0 100644 --- a/lib/skunk/rubycritic/analysed_modules_collection.rb +++ b/lib/skunk/rubycritic/analysed_modules_collection.rb @@ -8,7 +8,7 @@ class AnalysedModulesCollection def stink_score_average num_modules = @modules.size if num_modules.positive? - map(&:stink_score).reduce(:+) / num_modules.to_f + sum(&:stink_score) / num_modules.to_f else 0.0 end