This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Implement upward continuation and reduction to the pole in the frequency domain - #156
Merged
Conversation
Started cleaning up the code in fourier.py as well. Just a few more comments and moved the 2pi factor to frequencies (so they are wave numbers).
Need more complete docstring
Needs docstring
Only the x and y derivatives are tested because the z derivative appears to have a systematic error. I checked the formula and they seem correct. Might be a numerical error. Created #167 for this.
Conflicts: cookbook/gravmag_transform_tga.py fatiando/gravmag/fourier.py
Member
Author
|
Waiting for #196 to get the extra tests and fix to gridder. |
Conflicts: fatiando/gravmag/transform.py test/test_gravmag_transform.py
They were using the old the functions to calculate the frequencies and needed to be updated. Added equations and references to the docstrings. RTP now requires passing the source magnetization. This is to increase awareness that the magnetization is required. So better explicit than quietly using geomagnetic field direction.
Can't figure out accuracy.
Avoids edge effects in FFT
Works for reasonable accuracy constraints
Member
Author
|
The space domain approach doesn't work very well (doesn't pass the tests) and is quite slow to run. I'm thinking of getting rid of it in favour of FFT. Padding did great for edge effects. |
Member
Author
|
Testing
|
Testing against analytical solution. Works pretty well.
This is deprecated. I moved it to another function as a reference for how to do it. Also spell check the docs
leouieda
added a commit
that referenced
this pull request
Jul 11, 2015
Implement upward continuation and reduction to the pole in the frequency domain
Contributor
|
nice!! really nice!! |
Member
Author
|
👍 |
leouieda
added a commit
that referenced
this pull request
Jul 16, 2015
It was using the old syntax that allow for the space domain method (deprecated in #156).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two things to
fatiando.gravmag.transform:upcontinuefor upward continuation using the FFTreduce_to_polefor pole reduction of magnetic data using FFTChecklist: