New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement upward continuation and reduction to the pole in the frequency domain #156

Merged
merged 21 commits into from Jul 11, 2015

Conversation

Projects
None yet
2 participants
@leouieda
Member

leouieda commented Jan 6, 2015

This PR adds two things to fatiando.gravmag.transform:

  • Option to upcontinue for upward continuation using the FFT
  • Function reduce_to_pole for pole reduction of magnetic data using FFT

Checklist:

  • Make tests for new code
  • Create/update docstrings
  • Include relevant equations and citations in docstrings
  • Code follows PEP8 style conventions
  • Code and docs have been spellchecked
  • Include new dependencies in docs, requirements.txt, README
  • Documentation builds properly
  • All tests pass
  • Can be merged
  • Changelog entry

leouieda added some commits Dec 16, 2014

Add FFT up continue to recipe
Started cleaning up the code in fourier.py as well. Just a few more
comments and moved  the 2pi factor to frequencies (so they are wave
numbers).
FFT upward continuation
Need more complete docstring
FFT reduction to the pole
Needs docstring

@leouieda leouieda added this to the 0.4 milestone Jan 29, 2015

leouieda added some commits Feb 13, 2015

Test FFT derivs against analytical solutions
Only the x and y derivatives are tested because the z derivative appears
to have a systematic error. I checked the formula and they seem correct.
Might be a numerical error. Created #167 for this.
Merge branch 'master' into fourier-processing
Conflicts:
	cookbook/gravmag_transform_tga.py
	fatiando/gravmag/fourier.py
@leouieda

This comment has been minimized.

Member

leouieda commented Apr 30, 2015

Waiting for #196 to get the extra tests and fix to gridder.

leouieda added some commits May 29, 2015

Merge branch 'master' into fourier-processing
Conflicts:
	fatiando/gravmag/transform.py
	test/test_gravmag_transform.py
Docs with eqs and refs, fix rtp and upcontinue
They were using the old the functions to calculate the frequencies and
needed to be updated.

Added equations and references to the docstrings.

RTP now requires passing the source magnetization. This is to increase
awareness that the magnetization is required. So better explicit than
quietly using geomagnetic field direction.
Begin testing upcontinue. No luck.
Can't figure out accuracy.
Use padding in gravmag upcontinue by FFT
Avoids edge effects in FFT
Test upcontinue using abs difference
Works for reasonable accuracy constraints
@leouieda

This comment has been minimized.

Member

leouieda commented Jun 22, 2015

The space domain approach doesn't work very well (doesn't pass the tests) and is quite slow to run. I'm thinking of getting rid of it in favour of FFT. Padding did great for edge effects.

@leouieda

This comment has been minimized.

Member

leouieda commented Jun 22, 2015

Testing upcontinue almost done:

  • Make test for upcontinue using magnetic data.

leouieda added some commits Jun 23, 2015

Test the FFT pole reduction
Testing against analytical solution. Works pretty well.
Separate the space domain upcontinue
This is deprecated. I moved it to another function as a reference for
how to do it. Also spell check the docs

leouieda added a commit that referenced this pull request Jul 11, 2015

Merge pull request #156 from fatiando/fourier-processing
Implement upward continuation and reduction to the pole in the frequency domain

@leouieda leouieda merged commit a7d73b4 into master Jul 11, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@leouieda leouieda deleted the fourier-processing branch Jul 11, 2015

@eusoubrasileiro

This comment has been minimized.

Contributor

eusoubrasileiro commented Jul 11, 2015

nice!! really nice!!

@leouieda

This comment has been minimized.

Member

leouieda commented Jul 11, 2015

👍

leouieda added a commit that referenced this pull request Jul 16, 2015

Fix the transform.upcontinue recipe
It was using the old syntax that allow for the space domain method
(deprecated in #156).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment