New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill OpenMP parallelism in gravmag forward modeling #177

Merged
merged 6 commits into from Mar 18, 2015

Conversation

Projects
None yet
1 participant
@leouieda
Member

leouieda commented Mar 16, 2015

This causes so many install problems that it is not worth the small speed gain (see #164). Resulted in #165 to replace Cython OMP by Python multiprocessing.

This PR removes the prange from the Cython modules and stops linking omp to the compiled extensions. The install docs no longer need to mention installing TDM-Gcc in Windows.

A later PR will implement the higher level parallelism, probably simultaneously with the Cython/numba conversion (#169).

Checklist:

  • Make tests for new code
  • Create/update docstrings
  • Include relevant equations and citations in docstrings
  • Code follows PEP8 style conventions
  • Code and docs have been spellchecked
  • Include new dependencies in docs, requirements.txt, README, and .travis.yml
  • Documentation builds properly
  • All tests pass
  • Can be merged
  • Changelog entry

@leouieda leouieda added this to the 0.4 milestone Mar 16, 2015

@leouieda

This comment has been minimized.

Member

leouieda commented Mar 18, 2015

This solution seems to have worked for users having problems on MacOS (as this StackOverflow question).

leouieda added some commits Mar 16, 2015

Removed OMP prange from gravmag forward modeling
This is the main cause of install errors in Fatiando (#164)
Doesn't offer enough speedup and convenience to make it worth it.
Much better to use multiprocessing in pure Python.

First steps to #165
Remove TDMGCC part in install docs
No longer necessary since ditching openmp

@leouieda leouieda force-pushed the kill-omp branch from 32a2906 to e843770 Mar 18, 2015

leouieda added a commit that referenced this pull request Mar 18, 2015

Merge pull request #177 from fatiando/kill-omp
Kill OpenMP parallelism in gravmag forward modeling

@leouieda leouieda merged commit bf09661 into master Mar 18, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@leouieda leouieda deleted the kill-omp branch Mar 18, 2015

@leouieda leouieda restored the kill-omp branch Mar 18, 2015

@leouieda leouieda deleted the kill-omp branch Mar 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment