Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Kill OpenMP parallelism in gravmag forward modeling #177

Merged
merged 6 commits into from Mar 18, 2015
Merged

Conversation

leouieda
Copy link
Member

This causes so many install problems that it is not worth the small speed gain (see #164). Resulted in #165 to replace Cython OMP by Python multiprocessing.

This PR removes the prange from the Cython modules and stops linking omp to the compiled extensions. The install docs no longer need to mention installing TDM-Gcc in Windows.

A later PR will implement the higher level parallelism, probably simultaneously with the Cython/numba conversion (#169).

Checklist:

  • Make tests for new code
  • Create/update docstrings
  • Include relevant equations and citations in docstrings
  • Code follows PEP8 style conventions
  • Code and docs have been spellchecked
  • Include new dependencies in docs, requirements.txt, README, and .travis.yml
  • Documentation builds properly
  • All tests pass
  • Can be merged
  • Changelog entry

@leouieda leouieda added this to the 0.4 milestone Mar 16, 2015
@leouieda
Copy link
Member Author

This solution seems to have worked for users having problems on MacOS (as this StackOverflow question).

This is the main cause of install errors in Fatiando (#164)
Doesn't offer enough speedup and convenience to make it worth it.
Much better to use multiprocessing in pure Python.

First steps to #165
No longer necessary since ditching openmp
leouieda added a commit that referenced this pull request Mar 18, 2015
Kill OpenMP parallelism in gravmag forward modeling
@leouieda leouieda merged commit bf09661 into master Mar 18, 2015
@leouieda leouieda deleted the kill-omp branch March 18, 2015 19:15
@leouieda leouieda restored the kill-omp branch March 18, 2015 19:15
@leouieda leouieda deleted the kill-omp branch March 18, 2015 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant