Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Seismic vis (Obspy Integration)#192

Merged
leouieda merged 8 commits into
fatiando:masterfrom
eusoubrasileiro:seismic-vis
Apr 30, 2015
Merged

Seismic vis (Obspy Integration)#192
leouieda merged 8 commits into
fatiando:masterfrom
eusoubrasileiro:seismic-vis

Conversation

@eusoubrasileiro
Copy link
Copy Markdown
Contributor

Reopening PR 61 and PR 126 Obspy integration.

Simpler cookbook example where Obspy is just imported.

screenshot from 2015-04-15 15 23 26

  • Make tests for new code (ok then)
  • Create/update doc-strings
  • Update requirements
  • Code follows PEP8 style conventions
  • Code and docs have been spell-checked (perfect)
  • Changelog entry (doing now)
  • Documentation builds properly (builds properly)
  • All tests pass
  • Can be merged

@leouieda
Copy link
Copy Markdown
Member

👍

@eusoubrasileiro
Copy link
Copy Markdown
Contributor Author

Rsrs I got it hahah

Comment thread cookbook/vis_mpl_seismic.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eusoubrasileiro could you change the title to something like "plotting a seismic section"? The title should be something that a person will search for. Just to be clear, most of my titles for recipes are awful and need to be changed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it.

@leouieda
Copy link
Copy Markdown
Member

@eusoubrasileiro don't worry about the tests for now. We need to get all of fatiando.vis tested eventually but this will need a larger effort.

@leouieda
Copy link
Copy Markdown
Member

@eusoubrasileiro sorry I didn't the comment about tesseroids. The tesseroids tests are a bit slow but not as much as you're experiencing. The new code uses numba for speedups. If it's not installed, it runs the slow numpy version instead. So install numba with conda install numba and you'll see a very large speedup in the tests.

@leouieda
Copy link
Copy Markdown
Member

You can tick off the requirements item as well.

@eusoubrasileiro
Copy link
Copy Markdown
Contributor Author

@leouieda It`s done.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eusoubrasileiro final thing, I promise! Could you also add a line here saying something like "you can find instructions for installing Obspy at http://obspy.org/"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

@leouieda
Copy link
Copy Markdown
Member

@eusoubrasileiro perfect!

leouieda added a commit that referenced this pull request Apr 30, 2015
@leouieda leouieda merged commit cab653f into fatiando:master Apr 30, 2015
@eusoubrasileiro eusoubrasileiro deleted the seismic-vis branch April 30, 2015 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants