New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed software carpentry broken links. #245

Merged
merged 2 commits into from Dec 4, 2015

Conversation

Projects
None yet
2 participants
@drandykass
Contributor

drandykass commented Dec 4, 2015

Removed broken links to software carpentry pages and generalised them such that they point to software-carpentry.org. Changed the link description to allow the user to easily find the lesson. Added to changelog. Fixes #240

@leouieda

This comment has been minimized.

Member

leouieda commented Dec 4, 2015

@drandykass great! I'll download a copy to check that the docs build on my machine as well. In the mean time, could you add yourself to the doc/contributors.rst file?

@drandykass

This comment has been minimized.

Contributor

drandykass commented Dec 4, 2015

I did that on the pad_arrays commit (if you don't mind waiting for that
cycle to complete). Otherwise I can kill that change and put it here.

On Fri, Dec 4, 2015 at 11:17 AM, Leonardo Uieda notifications@github.com
wrote:

@drandykass https://github.com/drandykass great! I'll download a copy
to check that the docs build on my machine as well. In the mean time, could
you add yourself to the doc/contributors.rst file?


Reply to this email directly or view it on GitHub
#245 (comment).


Dum inter homines sumus, colamus humanitatem.

@leouieda

This comment has been minimized.

Member

leouieda commented Dec 4, 2015

Nope, that will be fine then! I'll just run this locally as a final check.

@leouieda

This comment has been minimized.

Member

leouieda commented Dec 4, 2015

OK, all things seem ready to go. Merging!

Congrats on the first PR (of many)!

leouieda added a commit that referenced this pull request Dec 4, 2015

Merge pull request #245 from drandykass/softcarp-devfix
Fixed software carpentry broken links.

@leouieda leouieda merged commit 25bf0cc into fatiando:master Dec 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@drandykass

This comment has been minimized.

Contributor

drandykass commented Dec 4, 2015

Let's hope so! Thanks for all your help. I'll get less needy as I get
experience.

On Fri, Dec 4, 2015 at 11:32 AM, Leonardo Uieda notifications@github.com
wrote:

Merged #245 #245.


Reply to this email directly or view it on GitHub
#245 (comment).


Dum inter homines sumus, colamus humanitatem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment