Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Fixed software carpentry broken links.#245

Merged
leouieda merged 2 commits into
fatiando:masterfrom
drandykass:softcarp-devfix
Dec 4, 2015
Merged

Fixed software carpentry broken links.#245
leouieda merged 2 commits into
fatiando:masterfrom
drandykass:softcarp-devfix

Conversation

@drandykass

Copy link
Copy Markdown
Contributor

Removed broken links to software carpentry pages and generalised them such that they point to software-carpentry.org. Changed the link description to allow the user to easily find the lesson. Added to changelog. Fixes #240

@leouieda

leouieda commented Dec 4, 2015

Copy link
Copy Markdown
Member

@drandykass great! I'll download a copy to check that the docs build on my machine as well. In the mean time, could you add yourself to the doc/contributors.rst file?

@drandykass

Copy link
Copy Markdown
Contributor Author

I did that on the pad_arrays commit (if you don't mind waiting for that
cycle to complete). Otherwise I can kill that change and put it here.

On Fri, Dec 4, 2015 at 11:17 AM, Leonardo Uieda notifications@github.com
wrote:

@drandykass https://github.com/drandykass great! I'll download a copy
to check that the docs build on my machine as well. In the mean time, could
you add yourself to the doc/contributors.rst file?


Reply to this email directly or view it on GitHub
#245 (comment).


Dum inter homines sumus, colamus humanitatem.

@leouieda

leouieda commented Dec 4, 2015

Copy link
Copy Markdown
Member

Nope, that will be fine then! I'll just run this locally as a final check.

@leouieda

leouieda commented Dec 4, 2015

Copy link
Copy Markdown
Member

OK, all things seem ready to go. Merging!

Congrats on the first PR (of many)!

leouieda added a commit that referenced this pull request Dec 4, 2015
Fixed software carpentry broken links.
@leouieda
leouieda merged commit 25bf0cc into fatiando:master Dec 4, 2015
@drandykass

Copy link
Copy Markdown
Contributor Author

Let's hope so! Thanks for all your help. I'll get less needy as I get
experience.

On Fri, Dec 4, 2015 at 11:32 AM, Leonardo Uieda notifications@github.com
wrote:

Merged #245 #245.


Reply to this email directly or view it on GitHub
#245 (comment).


Dum inter homines sumus, colamus humanitatem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants