This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Rename Euler deconvolution classes#286
Merged
Merged
Conversation
The new names are EulerDeconv, EulerDeconvMW (for moving window), EulerDeconvEW (for expanding window). These names won't clash with any other module and can be made part of the gravmag public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201
Renames the Euler deconvolution classes:
Classic(terrible name) is nowEulerDeconvMovingWindowis nowEulerDeconvMWandExpandingWindowis nowEulerDeconvEW. Both classes no longer take an euler solver as input. They are subclasses ofEulerDeconvand take the same parameters + the window parameters. This makes calling the functions simpler and less confusing for new users.These names won't clash with any other module and can be made part of the
fatiando.gravmagpublic API.Checklist:
doc/install.rst,requirements.txt,environment.yml, andREADME.rstmake docslocally)Notification for @fatiando/core-devs