This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Fixes error with tesseroid modeling on latest numba - #328
Merged
Conversation
10 tasks
leouieda
force-pushed
the
tesseroid-numba-latest
branch
from
November 26, 2016 18:31
6ce847d to
426b5e4
Compare
Only install Mayavi on the build that makes the docs. Run without on others to catch a bug in the tesseroid code with the latest numba.
The allocations were pushed the calling Python function. This breaks the numpy version of the code, which I disabled because it was practically unusable (so slow).
Also simplifies the ci shell scripts and use "set -e" to make them fail if any command inside fails.
Add some more verbosity to the script as well.
Of course putting it in ci/requirements-pip.txt wouldn't get run when running coverage, only when building the docs.
Add "set +e" to the end of scripts as suggested in travis-ci/travis-ci#6522
leouieda
force-pushed
the
tesseroid-numba-latest
branch
from
November 26, 2016 19:34
25691b2 to
0a257b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fatiando.gravmag.tesseroidcode fails with the latest numba (0.28). Thiswas uncaught because installing Mayavi limits numba to 0.26, where the error
doesn't occur. The problem was in the
engine_factoryfunction. Theloopliftargument to
numba.jitdoesn't seem to work anymore. The fix was to move thearray allocations out of the jitted function into the calling Python function.
This breaks the numpy only functions. They were too slow to be usable anyway so
I removed them from the code.
Caught the error by running the CI builds without installing Mayavi, but kept a
separate build with Mayavi to generate the documentation HTML. This forced to
configure the CI builds. Now there are separate builds for compiling the docs,
testing in Linux, and testing in OSX.
Checklist:
doc/install.rst,requirements.txt,environment.yml,ci/requirements-conda.txtandci/requirements-pip.txt.cd doc; makelocally)