Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency versions #109

Merged
merged 1 commit into from Jan 7, 2020
Merged

Upgrade dependency versions #109

merged 1 commit into from Jan 7, 2020

Conversation

@tliron
Copy link
Contributor

@tliron tliron commented Jan 7, 2020

Specifically important is the upgrade of github.com/mattn/go-isatty, because the older v0.0.3 was broken for WASM compilation.

I know you don't want to maintain this library anymore, but it's so useful! This is a small fix, I hope you can merge and release a new version of your library! Thank you!

@fatih
Copy link
Owner

@fatih fatih commented Jan 7, 2020

Sounds good, let's do it :) Can you also call please go mod tidy and go mod vendor ? We vendor the dependencies and I want to make sure it's up-to-date.

Specifically important is the upgrade of github.com/mattn/go-isatty,
because the older v0.0.3 was broken for WASM compilation
@tliron
Copy link
Contributor Author

@tliron tliron commented Jan 7, 2020

Done!

@fatih
Copy link
Owner

@fatih fatih commented Jan 7, 2020

Thank you @tliron

@fatih fatih merged commit 9ec1dc6 into fatih:master Jan 7, 2020
@fatih
Copy link
Owner

@fatih fatih commented Jan 7, 2020

Cut a new release with these changes: https://github.com/fatih/color/releases/tag/v1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants