Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom symbol for breakpoint. #2676

Merged
merged 3 commits into from Feb 3, 2020
Merged

Add custom symbol for breakpoint. #2676

merged 3 commits into from Feb 3, 2020

Conversation

louzp
Copy link
Contributor

@louzp louzp commented Jan 22, 2020

use let g:go_debug_break_point_symbol='>>' to add custom symbol for break point.

bhcleek
bhcleek requested changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@bhcleek bhcleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

Can you add documentation for the new config value and also give it the same treatment as the other config options by providing a getter in autoload/go/config.vim?

@louzp louzp changed the title Add custom symbol for break point. Add custom symbol for breakpoint. Jan 23, 2020
@louzp louzp requested a review from bhcleek January 23, 2020 01:12
@louzp
Copy link
Contributor Author

louzp commented Jan 23, 2020

Thanks for the suggestions.
I have modified the suggestions. Thanks for reviewing again

bhcleek
bhcleek approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@bhcleek bhcleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @louzp

Do you mind if I push to your branch before merging in order to adjust the documentation?

@louzp
Copy link
Contributor Author

louzp commented Jan 23, 2020

Thanks @louzp

Do you mind if I push to your branch before merging in order to adjust the documentation?

Thanks. No problem

@bhcleek
doc: edit documentation for g:go_debug_breakpoint_symbol
076091f
@bhcleek
config: remove whitespace
7c1e962 
Remove whitespace immediately following '(' and immediately before ')'.
@bhcleek bhcleek added this to the vim-go 1.23 milestone Jan 23, 2020
@bhcleek bhcleek merged commit fd1477d into fatih:master Feb 3, 2020
bhcleek added a commit that referenced this pull request Feb 3, 2020
@bhcleek
update CHANGELOG.md for #2676
bd2e839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhcleek bhcleek bhcleek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vim-go 1.23
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louzp @bhcleek