update for Go 1.19 #3441
Merged
update for Go 1.19 #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
force-pushed
the
go1.19
branch
7 times, most recently
from
55d617d
to
f140f23
Compare
Add new expectation introduced by revive.
golangci-lint seems to have finally fully dropped golint support, so refactor the tests that used golint to use revive instead.
Golangci-lint seems to have changed how it deals with some kinds of problems. Comment out the tests that no longer seem to be relevant instead of deleting them, because I don't trust that the original need for the tests won't reappear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update test to use Go 1.19
update Dockerfile to use Go 1.19
adjust tests for go1.19 changes to compiler errors
lint: add new expectation
Add new expectation introduced by revive.
lint: change metalinter tests to use revive
golangci-lint seems to have finally fully dropped golint support, so
refactor the tests that used golint to use revive instead.
lint: refactor for golangci-lint changed expectations
lint: adjust tests due to recent golangci-lint changes
Golangci-lint seems to have changed how it deals with some kinds of
problems. Comment out the tests that no longer seem to be relevant
instead of deleting them, because I don't trust that the original need
for the tests won't reappear.