syntax/go: do not treat builtins as keywords #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builtins have a very different property from keywords, the identifiers are settable. It is perfectly valid to override the builtins, though hopefully used sparingly. Instead of using `syn keyword`, we now use `syn match` and detect a function call by searching for an open parentheses.
|
Hi @mmlb Can you show me what this changes exactly? |
|
I ran into this because I was defining a https://play.golang.org/p/SmNjYyJq1J before: after: |
fatih
added a commit
that referenced
this pull request
Nov 22, 2015
syntax/go: do not treat builtins as keywords
|
Thanks @mmlb this makes totally sense. 👍 |
bhcleek
pushed a commit
to bhcleek/vim-go
that referenced
this pull request
Sep 2, 2018
This was changed from keywords to the regexp in fatih#605, but I think that was a mistake. If you do `new := "foo"` then this is perfectly valid Go, but I don't think it's a bad thing to add a reminder that you're actually overriding a global built-in by highlighting the `new`, just as it's not a bad idea to highlight the `new()` in `func new()` to serve as a similar reminder. This is a common-ish mistake that most of us have probably made at least once or twice. The only case where this fails is in method declaration and calls: func () x new() { other.new() } But this is the case with the current highlight as well, so it doesn't make that worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builtins have a very different property from keywords, the identifiers are
settable. It is perfectly valid to override the builtins, though hopefully used
sparingly.
Instead of using
syn keyword, we now usesyn matchand detect a functioncall by searching for an open parentheses.